-
Notifications
You must be signed in to change notification settings - Fork 3
Actions #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
========================================
+ Coverage 8.33% 9.08% +0.75%
========================================
Files 31 32 +1
Lines 3036 2521 -515
========================================
- Hits 253 229 -24
+ Misses 2762 2268 -494
- Partials 21 24 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func init() { | ||
| actionCmd.Flags().StringVarP(&actionParamsFile, "params", "p", "", "JSON parameter file to pass as stdin") | ||
| rootCmd.AddCommand(actionCmd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip cloud provider detection for the new action command
Registering actionCmd causes Execute to route through checkCloudProvider because the root command only bypasses that logic for init and version. Running onctl action … now requires ONCTL_CLOUD or a detectable cloud environment even though the action subcommand does not interact with any cloud provider. This makes the feature unusable on hosts that haven’t configured a provider. Consider adding the action command to the same exclusion list in Execute so it can run without cloud configuration.
Useful? React with 👍 / 👎.
No description provided.