-
-
Notifications
You must be signed in to change notification settings - Fork 51
Split every tab in two panes #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
gelisam
wants to merge
20
commits into
cdepillabout:master
Choose a base branch
from
gelisam:always-split
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
180472a
use Ctrl + keypad plus/minus to control font size
gelisam 7080542
typo
gelisam 51816b8
debugging function, printWidgetTree
gelisam e03bda2
prototype: put terminals inside a Paned
gelisam 240f1d8
rename TabTermContainer to TabScrolledWindow
gelisam e5226ed
track the Paned in the TMNotebookTab
gelisam 43d04e7
look for the Paned, not the ScrolledWindow
gelisam e582ec2
include Paned field in Show instance
gelisam 5a6afe6
detach the Paned on terminal exit
gelisam b8aa4b0
correct TMNotebookTab's comment
gelisam 484ed1d
relabel based on the Paned
gelisam 1cb1bc9
more straightforward invariant checks
gelisam c1d0834
two terminals per tab
gelisam 4088f70
split the space equally between terminals
gelisam a0618c0
track both terminals in the TMNotebookTab
gelisam 9c06b97
hotkeys to navigate between panes
gelisam bbcd3fa
update comment to reflect focuslist-0.1.1.0 release
gelisam 6dd0c15
move printWidgetTree to Termonad.Gtk
gelisam 9568b68
adding myself as a co-maintainer
gelisam 8913213
Merge branch 'master' into always-split
gelisam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this function in order to help me debug my implementation, but the now-debugged code is not using it anywhere, so I should probably remove it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice. I've wanted something like this before, so I opened an issue on haskell-gi to see if it could potentially be included in
gi-gtk: haskell-gi/haskell-gi#374I don't think it makes sense to only have this in the Termonad codebase, since it seems widely helpful.
Although, if this type of function is not accepted upstream, let's move it to the
Termonad.Gtkmodule, since there are already a few other helper functions in there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now moved
printWidgetTreetoTermonad.Gtk, let's remove when/if it is accepted upstream.