AVC: Check for custom_crf before access
#652
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this error on startup:
```
2025-05-03 08:31:08 leela fastflix[45905] INFO Running task Initialize Encoders
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 504, in __getitem__
return super().__getitem__(item)
^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'custom_crf'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 537, in __getattr__
value = self.__getitem__(item, _ignore_default=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 525, in __getitem__
raise BoxKeyError(str(err)) from _exception_cause(err)
box.exceptions.BoxKeyError: "'custom_crf'"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 539, in __getattr__
value = object.__getattribute__(self, item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Box' object has no attribute 'custom_crf'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/fastflix/encoders/common/setting_panel.py", line 378, in <lambda>
self.widgets.bitrate_passes.currentIndexChanged.connect(lambda: self.mode_update())
^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/fastflix/encoders/avc_x264/settings_panel.py", line 157, in mode_update
self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 553, in __getattr__
raise BoxKeyError(str(err)) from _exception_cause(err)
box.exceptions.BoxKeyError: "'Box' object has no attribute 'custom_crf'"
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 504, in __getitem__
return super().__getitem__(item)
^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'custom_crf'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 537, in __getattr__
value = self.__getitem__(item, _ignore_default=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 525, in __getitem__
raise BoxKeyError(str(err)) from _exception_cause(err)
box.exceptions.BoxKeyError: "'custom_crf'"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 539, in __getattr__
value = object.__getattribute__(self, item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Box' object has no attribute 'custom_crf'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/noelle/dev/FastFlix/fastflix/encoders/common/setting_panel.py", line 378, in <lambda>
self.widgets.bitrate_passes.currentIndexChanged.connect(lambda: self.mode_update())
^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/fastflix/encoders/avc_x264/settings_panel.py", line 157, in mode_update
self.widgets.custom_crf.setDisabled(self.widgets.crf.currentText() != "Custom")
^^^^^^^^^^^^^^^^^^^^^^^
File "/home/noelle/dev/FastFlix/.venv/lib/python3.12/site-packages/box/box.py", line 553, in __getattr__
raise BoxKeyError(str(err)) from _exception_cause(err)
box.exceptions.BoxKeyError: "'Box' object has no attribute 'custom_crf'"
```
Owner
|
Hi Noelle, thanks for the fix. Thankfully I found the root cause (think due to updated pyside6 version and where the connector was set) so will prevent anywhere with the custom_crf from having issue. Plan to do release later today! |
Owner
|
Fixed in 5.12.0 https://github.com/cdgriffith/FastFlix/releases/tag/5.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error on startup: