feat: data source for vended log types #2204

ShadowCat567 · 2025-11-12T21:20:31Z

Adds new data source to populate logTypes attribute for Cloudformation resources. Does not add github actions to update the data source (for now).

…ec into loggroupsource

mrgrain · 2025-11-13T16:45:42Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

  readonly validations?: unknown;
  arnTemplate?: string;
  isStateful?: boolean;
+  logTypes?: string[];


This is probably not quite enough. Let's make this a list of a new custom type VendedLogs. See slack discussion for details on what needs to go there.

ShadowCat567 · 2025-11-14T17:56:53Z

packages/@aws-cdk/service-spec-importers/src/importers/import-log-source.ts

+  >,
+  report: ProblemReport,
+) {
+  // clears vendedLogs property from all resources before processing - goal: ensure that logTypes and destinations are up to date and cut down on complicated deduplication code


Open to other ideas to handle possible duplication of logTypes (when it comes to repeated imports of data source) or removal of logTypes (if a service stops supporting a certain logType). This current implementation is a bit aggressive.

You just don't need to do that at all. The DB starts out empty.

mrgrain · 2025-11-17T13:32:48Z

packages/@aws-cdk/service-spec-importers/src/importers/import-log-source.ts

+  for (const resource of db.all('resource')) {
+    if (resource.vendedLogs) {
+      delete resource.vendedLogs;
+    }
+  }


Suggested change

for (const resource of db.all('resource')) {

if (resource.vendedLogs) {

delete resource.vendedLogs;

}

}

mrgrain · 2025-11-17T13:34:26Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

+  /**
+   * What version of permissions the destination supports V1 | V2
+   */
+  permissionsVersion: string;


Suggested change

permissionsVersion: string;

readonly permissionsVersion: string;

mrgrain · 2025-11-17T13:36:08Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

+  /**
+   * List of the destinations the can consume those logs
+   */
+  readonly logDestinations: LogDestination[];


Prefer to remove duplicate naming. In this context, its pretty clear we are talking about log destinations.

Suggested change

readonly logDestinations: LogDestination[];

readonly destinations: LogDestination[];

mrgrain · 2025-11-17T13:38:09Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

+  /**
+   * List of the types of logs a Cloudformation resource can produce
+   */
+  readonly logTypes: string[];


Normally you would consider removing the log prefix here as well (see next comment). In this case it's probably okay to keep it because A/ types is very generic (probably too generic) and B/ it's the term used here.

So I vote to keep it in this case.

mrgrain · 2025-11-17T13:39:59Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

+  /**
+   * Resource type of the destination S3 | CWL | FH | XRAY
+   */
+  readonly destinationType: string;


Again doubling up. Here I think it's fine to remove the prefix. You could also call it something like service or not even have a separate interface.

Suggested change

readonly destinationType: string;

readonly type: string;

currently have this as a separate interface since we may want logFormat (json, parquet, plain text, raw...) in the future and that can vary per destination service

Both is fine. My usual approach is to not over-optimize for future possibilities.

ended up moving this out of its separate interface since it will be easier to handle and we currently don't have plans to add logFormat or any service-specific fields that would require the separate interface

mrgrain · 2025-11-17T13:40:38Z

packages/@aws-cdk/service-spec-types/src/types/resource.ts

+  /**
+   * Resource type of the destination S3 | CWL | FH | XRAY
+   */
+  readonly destinationType: string;


There should be no reason to not strongly type this:

Suggested change

readonly destinationType: string;

readonly destinationType: "S3" | "CWL" | "FH" | "XRAY";

mrgrain · 2025-11-17T13:44:18Z

packages/@aws-cdk/service-spec-importers/src/importers/import-log-source.ts

+        let permissionValue = '';
+        for (const dest of value.Destinations) {
+          if (permissionValue === '') {
+            permissionValue = dest.PermissionsVersion;
+          } else {
+            if (permissionValue !== dest.PermissionsVersion) {
+              report.reportFailure(
+                new ReportAudience('Log Source Import'),
+                'interpreting',
+                failure.in(resourceType)(
+                  `Resouce of type ${resourceType} has inconsistent permissions version for log of type ${value.LogType}`,
+                ),
+              );
+            }
+          }


You can simplify this a lot along these lines

Suggested change

let permissionValue = '';

for (const dest of value.Destinations) {

if (permissionValue === '') {

permissionValue = dest.PermissionsVersion;

} else {

if (permissionValue !== dest.PermissionsVersion) {

report.reportFailure(

new ReportAudience('Log Source Import'),

'interpreting',

failure.in(resourceType)(

`Resouce of type ${resourceType} has inconsistent permissions version for log of type ${value.LogType}`,

),

);

}

}

const permissionValue = Value.Destinations[0].PermissionsVersion;

if (!value.Destinations.every(v => v.PermissionsVersion === permissionValue)) {

// ... report failure

}

mrgrain · 2025-11-17T13:49:34Z

packages/@aws-cdk/service-spec-importers/src/importers/import-log-source.ts

+        if (resource.vendedLogs) {
+          // we take whatever the newest permissions value is and assume that all logs in a resource use the same permissions
+          resource.vendedLogs.permissionsVersion = permissionValue;
+          resource.vendedLogs.logTypes.push(value.LogType);
+          // dedupes incoming destinations
+          const newDestinations = destinations.filter(
+            (dest) =>
+              !resource.vendedLogs!.logDestinations.some(
+                (existing) => existing.destinationType === dest.destinationType,
+              ),
+          );
+          resource.vendedLogs.logDestinations.push(...newDestinations);
+        } else {
+          resource.vendedLogs = {
+            permissionsVersion: permissionValue,
+            logTypes: [value.LogType],
+            logDestinations: destinations,
+          };
+        }


Simplify by flipping it around:

??= = Nullish coalescing assignment

Suggested change

if (resource.vendedLogs) {

// we take whatever the newest permissions value is and assume that all logs in a resource use the same permissions

resource.vendedLogs.permissionsVersion = permissionValue;

resource.vendedLogs.logTypes.push(value.LogType);

// dedupes incoming destinations

const newDestinations = destinations.filter(

(dest) =>

!resource.vendedLogs!.logDestinations.some(

(existing) => existing.destinationType === dest.destinationType,

),

);

resource.vendedLogs.logDestinations.push(...newDestinations);

} else {

resource.vendedLogs = {

permissionsVersion: permissionValue,

logTypes: [value.LogType],

logDestinations: destinations,

};

}

resource.vendedLogs ??= {};

resource.vendedLogs.logTypes ??= [];

resource.vendedLogs.logDestinations ??= [];

// we take whatever the newest permissions value is and assume that all logs in a resource use the same permissions

resource.vendedLogs.permissionsVersion = permissionValue;

// Add log types

resource.vendedLogs.logTypes.push(value.LogType);

// dedupes incoming destinations

const newDestinations = destinations.filter(

(dest) =>

!resource.vendedLogs!.logDestinations.some(

(existing) => existing.destinationType === dest.destinationType,

),

);

resource.vendedLogs.logDestinations.push(...newDestinations);

mrgrain

Some minor inline comments

│            └logDestinations: [{"destinationType":"S3"}, {"destinationType":"CWL"}, {"destinationType":"FH"}]

If you keep LogDestination as an interface type, let's please simplify this diff to

│            └logDestinations: [S3, CW,  FH]

If you change LogDestination to be a string (or rather S3, CW, FH, XRAY) this should happen more or less for free.

github-actions · 2025-11-17T16:29:20Z

@aws-cdk/aws-service-spec: Model database diff detected
📁 Download full diff

├[~] service aws-aps
│ └ resources
│    ├[~]  resource AWS::APS::Scraper
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V1
│    │       ├logTypes: [APPLICATION_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::APS::Workspace
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [MANAGED_PROMETHEUS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-b2bi
│ └ resources
│    └[~]  resource AWS::B2BI::Transformer
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [B2BI_EXECUTION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-backupgateway
│ └ resources
│    └[~]  resource AWS::BackupGateway::Hypervisor
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [BGW_HYPERVISOR_LOGS, DATA_ACCESS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-bedrock
│ └ resources
│    ├[~]  resource AWS::Bedrock::Agent
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [APPLICATION_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    ├[~]  resource AWS::Bedrock::AgentAlias
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [EVENT_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    ├[~]  resource AWS::Bedrock::Flow
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [APPLICATION_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::Bedrock::KnowledgeBase
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [APPLICATION_LOGS, RUNTIME_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-bedrockagentcore
│ └ resources
│    ├[~]  resource AWS::BedrockAgentCore::Gateway
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [APPLICATION_LOGS, TRACES]
│    │       └destinations: [S3, CWL, FH, XRAY]
│    ├[~]  resource AWS::BedrockAgentCore::Memory
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [APPLICATION_LOGS, TRACES]
│    │       └destinations: [S3, CWL, FH, XRAY]
│    └[~]  resource AWS::BedrockAgentCore::Runtime
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [APPLICATION_LOGS, TRACES, USAGE_LOGS]
│            └destinations: [S3, CWL, FH, XRAY]
├[~] service aws-cleanrooms
│ └ resources
│    └[~]  resource AWS::CleanRooms::Membership
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ANALYSIS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-cloudfront
│ └ resources
│    └[~]  resource AWS::CloudFront::Distribution
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [CONNECTION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-cognito
│ └ resources
│    └[~]  resource AWS::Cognito::UserPool
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [APPLICATION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-connect
│ └ resources
│    └[~]  resource AWS::Connect::Instance
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [AMAZON_CONNECT_FLOW_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-ec2
│ └ resources
│    ├[~]  resource AWS::EC2::RouteServerPeer
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [EVENT_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    ├[~]  resource AWS::EC2::VerifiedAccessInstance
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V1
│    │       ├logTypes: [VERIFIED_ACCESS_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    ├[~]  resource AWS::EC2::VPC
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V1
│    │       ├logTypes: [ROUTE53_RESOLVER_QUERY_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::EC2::VPNConnection
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [EVENT_LOGS, CONNECTION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-eks
│ └ resources
│    └[~]  resource AWS::EKS::Cluster
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [AUTO_MODE_BLOCK_STORAGE_LOGS, AUTO_MODE_COMPUTE_LOGS, AUTO_MODE_IPAM_LOGS, AUTO_MODE_LOAD_BALANCING_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-elasticache
│ └ resources
│    └[~]  resource AWS::ElastiCache::CacheCluster
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ELASTICACHE_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-elasticloadbalancingv2
│ └ resources
│    └[~]  resource AWS::ElasticLoadBalancingV2::LoadBalancer
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [NLB_ACCESS_LOGS]
│            └destinations: [S3]
├[~] service aws-entityresolution
│ └ resources
│    ├[~]  resource AWS::EntityResolution::IdMappingWorkflow
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [WORKFLOW_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::EntityResolution::MatchingWorkflow
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [WORKFLOW_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-events
│ └ resources
│    └[~]  resource AWS::Events::EventBus
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [ERROR_LOGS, INFO_LOGS, TRACE_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-grafana
│ └ resources
│    └[~]  resource AWS::Grafana::Workspace
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [APPLICATION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-iotfleetwise
│ └ resources
│    ├[~]  resource AWS::IoTFleetWise::Campaign
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V1
│    │       ├logTypes: [IOT_FLEETWISE_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::IoTFleetWise::Vehicle
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [IOT_FLEETWISE_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-ivschat
│ └ resources
│    └[~]  resource AWS::IVSChat::Room
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [IVS_CHAT_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-kafkaconnect
│ └ resources
│    └[~]  resource AWS::KafkaConnect::Connector
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [APPLICATION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-m2
│ └ resources
│    └[~]  resource AWS::M2::Application
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [CONFIG_LOGS, BATCH_JOB_LOGS, CONSOLE_LOGS, DATASET_IMPORT_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-mediapackagev2
│ └ resources
│    └[~]  resource AWS::MediaPackageV2::ChannelGroup
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [EGRESS_ACCESS_LOGS, INGRESS_ACCESS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-mediatailor
│ └ resources
│    └[~]  resource AWS::MediaTailor::PlaybackConfiguration
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [AD_DECISION_SERVER_LOGS, MANIFEST_SERVICE_LOGS, TRANSCODE_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-msk
│ └ resources
│    └[~]  resource AWS::MSK::Cluster
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [BROKER_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-networkfirewall
│ └ resources
│    └[~]  resource AWS::NetworkFirewall::Firewall
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ALERT_LOGS, FLOW_LOGS, TLS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-organizations
│ └ resources
│    └[~]  resource AWS::Organizations::Organization
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [ACCESS_CONTROL_LOGS, AUTHENTICATION_LOGS, WORKMAIL_AVAILABILITY_PROVIDER_LOGS, WORKMAIL_MAILBOX_ACCESS_LOGS, WORKMAIL_PERSONAL_ACCESS_TOKEN_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-osis
│ └ resources
│    └[~]  resource AWS::OSIS::Pipeline
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [PIPELINE_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-pcs
│ └ resources
│    └[~]  resource AWS::PCS::Cluster
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [PCS_JOBCOMP_LOGS, PCS_SCHEDULER_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-pipes
│ └ resources
│    └[~]  resource AWS::Pipes::Pipe
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [EXECUTION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-qbusiness
│ └ resources
│    └[~]  resource AWS::QBusiness::Application
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [SYNC_JOB_LOGS, EVENT_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-route53profiles
│ └ resources
│    └[~]  resource AWS::Route53Profiles::Profile
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ROUTE53_PROFILES_RESOLVER_QUERY_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-rum
│ └ resources
│    └[~]  resource AWS::RUM::AppMonitor
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [RUM_TELEMETRY_LOGS, RUM_OTEL_LOGS, RUM_OTEL_SPANS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-sagemaker
│ └ resources
│    └[~]  resource AWS::SageMaker::Workteam
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ACTIVITY_LOGS]
│            └destinations: [S3, CWL]
├[~] service aws-ses
│ └ resources
│    ├[~]  resource AWS::SES::MailManagerIngressPoint
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V2
│    │       ├logTypes: [APPLICATION_LOGS, TRAFFIC_POLICY_DEBUG_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::SES::MailManagerRuleSet
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [APPLICATION_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-shield
│ └ resources
│    └[~]  resource AWS::Shield::Protection
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V2
│            ├logTypes: [FLOW_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-stepfunctions
│ └ resources
│    └[~]  resource AWS::StepFunctions::StateMachine
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [EXPRESS_LOGS, STANDARD_LOGS]
│            └destinations: [CWL]
├[~] service aws-transfer
│ └ resources
│    └[~]  resource AWS::Transfer::Server
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [TRANSFER_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-vpclattice
│ └ resources
│    ├[~]  resource AWS::VpcLattice::ResourceConfiguration
│    │  └ vendedLogs
│    │     └[+] vendedLogs
│    │       ├permissionsVersion: V1
│    │       ├logTypes: [RESOURCE_ACCESS_LOGS]
│    │       └destinations: [S3, CWL, FH]
│    └[~]  resource AWS::VpcLattice::Service
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ACCESS_LOGS]
│            └destinations: [S3, CWL, FH]
├[~] service aws-wafv2
│ └ resources
│    └[~]  resource AWS::WAFv2::WebACL
│       └ vendedLogs
│          └[+] vendedLogs
│            ├permissionsVersion: V1
│            ├logTypes: [ACCESS_LOGS, TOKEN_LOGS]
│            └destinations: [S3, CWL, FH]
└[~] service aws-wisdom
  └ resources
     └[~]  resource AWS::Wisdom::Assistant
        └ vendedLogs
           └[+] vendedLogs
             ├permissionsVersion: V2
             ├logTypes: [EVENT_LOGS]
             └destinations: [S3, CWL, FH]

aws-amplify-bot and others added 6 commits November 12, 2025 16:17

add logtypes data source

30fb0e5

Merge branch 'main' into loggroupsource

ff9285c

Merge branch 'main' into loggroupsource

342624a

importing log sources

4b7a4b1

Merge branch 'loggroupsource' of github.com:cdklabs/awscdk-service-sp…

e15d4d3

…ec into loggroupsource

fixes and adjustments

44d2638

This comment was marked as outdated.

Sign in to view

cdklabs deleted a comment from github-actions bot Nov 13, 2025

mrgrain reviewed Nov 13, 2025

View reviewed changes

aws-amplify-bot added 2 commits November 14, 2025 10:08

updated types and data source

45d8d52

alter type, update log source importing

f2a30b4

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into loggroupsource

e1dfd80

This comment was marked as outdated.

Sign in to view

ShadowCat567 commented Nov 14, 2025

View reviewed changes

aws-amplify-bot added 2 commits November 14, 2025 13:58

special formatting for vended logs diff

fb61126

actually add the custom diff handling for vended logs

8ce68ad

This comment was marked as outdated.

Sign in to view

update vended logs printing to make logDestinations more future proof

c56ff06

This comment was marked as outdated.

Sign in to view

mrgrain reviewed Nov 17, 2025

View reviewed changes

mrgrain requested changes Nov 17, 2025

View reviewed changes

updates from feedback

b0d696c

This comment was marked as outdated.

Sign in to view

minor message adjustment

2e68892

mrgrain changed the title ~~feat: new data source for log types~~ feat: data source for vended log types Nov 17, 2025

ShadowCat567 marked this pull request as ready for review November 17, 2025 16:24

aws-cdk-automation enabled auto-merge November 17, 2025 16:24

Merge branch 'main' into loggroupsource

d4716b4

mrgrain approved these changes Nov 17, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

aws-cdk-automation added this pull request to the merge queue Nov 17, 2025

Merged via the queue into main with commit c355286 Nov 17, 2025
10 checks passed

aws-cdk-automation deleted the loggroupsource branch November 17, 2025 16:45

	permissionsVersion: string;
	readonly permissionsVersion: string;

	readonly logDestinations: LogDestination[];
	readonly destinations: LogDestination[];

	readonly destinationType: string;
	readonly destinationType: "S3" \| "CWL" \| "FH" \| "XRAY";

feat: data source for vended log types #2204

feat: data source for vended log types #2204

Uh oh!

Conversation

ShadowCat567 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

mrgrain Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrgrain Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShadowCat567 Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrgrain left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented Nov 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ShadowCat567 commented Nov 12, 2025 •

edited

Loading

mrgrain Nov 17, 2025 •

edited

Loading

mrgrain Nov 17, 2025 •

edited

Loading

ShadowCat567 Nov 17, 2025 •

edited

Loading