refactor: move common types to separate file #2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@aws-cdk/aws-service-spec: No model change detected |
rix0rrr
approved these changes
Nov 17, 2025
Contributor
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
Provisionally approved, I'd like you to add some sugar to make the usage sites nicer (and potentially the diff smaller, if you so care)
| @@ -0,0 +1,73 @@ | |||
| import { Entity, Reference } from '@cdklabs/tskb'; | |||
|
|
|||
| export type PropertyType<T extends Entity> = | |||
Contributor
There was a problem hiding this comment.
Add a line of documentation saying what T is for.
Also add a type alias in the original location so the consumer sites look nicer:
export type ResourcePropertyType = PropertyType<TypeDefinition>;(Alternatively, make PropertyType the alias and give the parameterized type a different name, like GenericPropertyType<T>, to minimize the diff)
Contributor
Author
There was a problem hiding this comment.
Add a line of documentation saying what T is for.
Forget to do this, but hopefully will do it in later PRs :D
gasolima
force-pushed
the
refactor-common-types
branch
2 times, most recently
from
f13471c to
9a9a7e0
Compare
gasolima
force-pushed
the
refactor-common-types
branch
from
9a9a7e0 to
57104e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to put the common types in a separate file, and use proper generics instead of unions