fix: loading database crashes if collections are missing #2237
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasolima
changed the title
rix0rrr
requested changes
Nov 24, 2025
| } | ||
| if (!!proto && typeof proto === 'object' && !!x && typeof x === 'object') { | ||
| for (const [k, v] of Object.entries(proto)) { | ||
| hydrate(v, (x as any)[k]); |
Contributor
There was a problem hiding this comment.
Better to add the check here, no?
rix0rrr
changed the title
rix0rrr
approved these changes
Nov 24, 2025
Contributor
|
@aws-cdk/aws-service-spec: No model change detected |
1 task
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Nov 24, 2025
### Issue # (if applicable) This PR picking up the [diff db](cdklabs/awscdk-service-spec#2237) fix, to be able to review the changes happening in the PRs for L1s ### Reason for this change ### Description of changes ### Describe any new or updated permissions being added ### Description of how you validated changes ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
…rvice-spec-types (#2238) Should have been released with #2237 but didn't. Now we are forcing the release of these packages. --------- Co-authored-by: Momo Kornher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database
.load()function was expecting that the data file would always conform to the exact (collection) schema that was defined in the database.In general this should be true, but there is one exception:
Instead, we will treat the missing keys as empty.