Skip to content

fix: rendering vended log diffs #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 3 commits into from
Nov 25, 2025
Merged

fix: rendering vended log diffs #2243

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cc54b9
fix rendering for vended logs lists
Nov 25, 2025
578a341
change var name
Nov 25, 2025
62dc3a7
chore: self mutation
github-actions[bot] Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/@aws-cdk/service-spec-importers/src/diff-fmt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,14 +373,15 @@ export class DiffFormatter {

private renderVendedLogListDiff(diff: ScalarDiff<VendedLog | undefined>, tree: PrintableTree[], diffShown: string) {
if (diff.old && diff.new) {
const oldList = new Set(diff.old.logTypes);
const newList = new Set(diff.new.logTypes);
const addedTypes = [...newList].filter((t) => !oldList.has(t));
const removedTypes = [...oldList].filter((t) => !newList.has(t));
if (addedTypes.length > 0 || removedTypes.length > 0) {
// the array should correspond to the value of diffShown
const oldList = new Set(diffShown === 'logTypes' ? diff.new.logTypes : diff.new.destinations);
const newList = new Set(diffShown === 'logTypes' ? diff.new.logTypes : diff.new.destinations);
const added = [...newList].filter((t) => !oldList.has(t));
const removed = [...oldList].filter((t) => !newList.has(t));
if (added.length > 0 || removed.length > 0) {
const bullets: PrintableTree[] = [];
removedTypes.forEach((type) => bullets.push(new PrintableTree(`- ${type}`).colorize(chalk.red)));
addedTypes.forEach((type) => bullets.push(new PrintableTree(`+ ${type}`).colorize(chalk.green)));
removed.forEach((obj) => bullets.push(new PrintableTree(`- ${obj}`).colorize(chalk.red)));
added.forEach((obj) => bullets.push(new PrintableTree(`+ ${obj}`).colorize(chalk.green)));
tree.push(new PrintableTree(`${diffShown}:`).addBullets(bullets));
}
}
Expand Down
Loading