fix: do not print event diff when the ids have changed #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2248
Description of the bug
When checking for the database diff, the
eventRootPropertyandeventResourcesFieldof events were shown as changing like:This was caused because they used
JsonEqfor comparison, which also checked if they has the same$idin the db, which is not always true (e.g. when adding a new resource to the db, ids will change).Solution
Do not compare the ids, but use the existing functions to compare the
EvenTypeDefinitionin these properties.Testing