fix(typewriter): change type from ThisInstance to Expression #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/typewriter/this-expression-type
branch
from
a4ce8b0 to
84caf23
Compare
Contributor
|
@aws-cdk/aws-service-spec: No model change detected |
iliapolo
approved these changes
Nov 28, 2025
aws-cdk-automation
deleted the
mrgrain/fix/typewriter/this-expression-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reason, when operating in a large repo like aws/aws-cdk, using the
$thishelper causes the type checker to fail and "ignore" theExpressionProxypart of the type. This then causes a lot of type errors. Only happens in the IDE and is not consistent.I tested a few things and changing the type of
$thisfromExpressionProxy<ThisInstance>toExpressionProxy<Expression>seems to fix it. This is okay, becauseThisInstancecurrently just extendsExpression. And in any case the helper is intended to be used as a proxy, not asThisInstanceitself.It's not really a satisfying solution, but a practical one.