generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 19
feat: introduce transitional property vendedLogsConfig and new type VendedLogs
#2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@aws-cdk/aws-service-spec: Model database diff detected |
vendedLogsConfigvendedLogsConfig
vendedLogsConfigvendedLogsConfig and new type VendedLogs
mrgrain
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starts updating type for VendedLogs.
Adds a new properly onto
Resourcewhich will take the place of the currentvendedLogsproperty,vendedLogsConfig.In
vendedLogsConfig, destination resources are now affiliated per log type instead of per resource and is an array of logTypes, which means its typing looks like this:instead of this:
Why should we do this? Not all
logTypesthat a resource supports can deliver to the same destinations (most notably,TRACEScan only deliver toXRAYand no other log type can deliver toXRAY)