Skip to content

feat: vendedLogs uses new type, remove traces of old type #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aws-cdk-automation merged 2 commits into from
Dec 18, 2025
Merged

feat: vendedLogs uses new type, remove traces of old type #2310

aws-cdk-automation merged 2 commits into from
Dec 18, 2025

Conversation

@ShadowCat567
Copy link
Contributor

@ShadowCat567 ShadowCat567 commented Dec 17, 2025 •
edited
Loading

Stage 2 of switching vendedLogs to use the new type. Remove traces of old type (VendedLog) and have vendedLogs now use type VendedLogs[].

Remove do-not-merge label when this PR is merged (and re-run PR checks): aws/aws-cdk#36431

@ShadowCat567 ShadowCat567 added the do-not-merge Do not merge this PR until further notice label Dec 17, 2025
@ShadowCat567 ShadowCat567 marked this pull request as ready for review December 17, 2025 20:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

@aws-cdk/aws-service-spec: Model database diff detected
📁 Download full diff

├[~] service aws-aps
│ └ resources
│    ├[~]  resource AWS::APS::Scraper
│    └[~]  resource AWS::APS::Workspace
├[~] service aws-b2bi
│ └ resources
│    └[~]  resource AWS::B2BI::Transformer
├[~] service aws-backupgateway
│ └ resources
│    └[~]  resource AWS::BackupGateway::Hypervisor
├[~] service aws-bedrock
│ └ resources
│    ├[~]  resource AWS::Bedrock::Agent
│    ├[~]  resource AWS::Bedrock::AgentAlias
│    ├[~]  resource AWS::Bedrock::Flow
│    └[~]  resource AWS::Bedrock::KnowledgeBase
├[~] service aws-bedrockagentcore
│ └ resources
│    ├[~]  resource AWS::BedrockAgentCore::BrowserCustom
│    ├[~]  resource AWS::BedrockAgentCore::CodeInterpreterCustom
│    ├[~]  resource AWS::BedrockAgentCore::Gateway
│    ├[~]  resource AWS::BedrockAgentCore::Memory
│    ├[~]  resource AWS::BedrockAgentCore::Runtime
│    └[~]  resource AWS::BedrockAgentCore::WorkloadIdentity
├[~] service aws-cleanrooms
│ └ resources
│    └[~]  resource AWS::CleanRooms::Membership
├[~] service aws-cloudfront
│ └ resources
│    └[~]  resource AWS::CloudFront::Distribution
├[~] service aws-cognito
│ └ resources
│    └[~]  resource AWS::Cognito::UserPool
├[~] service aws-connect
│ └ resources
│    └[~]  resource AWS::Connect::Instance
├[~] service aws-ec2
│ └ resources
│    ├[~]  resource AWS::EC2::RouteServerPeer
│    ├[~]  resource AWS::EC2::VerifiedAccessInstance
│    ├[~]  resource AWS::EC2::VPC
│    └[~]  resource AWS::EC2::VPNConnection
├[~] service aws-eks
│ └ resources
│    └[~]  resource AWS::EKS::Cluster
├[~] service aws-elasticache
│ └ resources
│    └[~]  resource AWS::ElastiCache::CacheCluster
├[~] service aws-elasticloadbalancingv2
│ └ resources
│    └[~]  resource AWS::ElasticLoadBalancingV2::LoadBalancer
├[~] service aws-entityresolution
│ └ resources
│    ├[~]  resource AWS::EntityResolution::IdMappingWorkflow
│    └[~]  resource AWS::EntityResolution::MatchingWorkflow
├[~] service aws-events
│ └ resources
│    └[~]  resource AWS::Events::EventBus
├[~] service aws-grafana
│ └ resources
│    └[~]  resource AWS::Grafana::Workspace
├[~] service aws-iotfleetwise
│ └ resources
│    ├[~]  resource AWS::IoTFleetWise::Campaign
│    └[~]  resource AWS::IoTFleetWise::Vehicle
├[~] service aws-ivschat
│ └ resources
│    └[~]  resource AWS::IVSChat::Room
├[~] service aws-kafkaconnect
│ └ resources
│    └[~]  resource AWS::KafkaConnect::Connector
├[~] service aws-m2
│ └ resources
│    └[~]  resource AWS::M2::Application
├[~] service aws-mediapackagev2
│ └ resources
│    └[~]  resource AWS::MediaPackageV2::ChannelGroup
├[~] service aws-mediatailor
│ └ resources
│    └[~]  resource AWS::MediaTailor::PlaybackConfiguration
├[~] service aws-msk
│ └ resources
│    └[~]  resource AWS::MSK::Cluster
├[~] service aws-networkfirewall
│ └ resources
│    └[~]  resource AWS::NetworkFirewall::Firewall
├[~] service aws-osis
│ └ resources
│    └[~]  resource AWS::OSIS::Pipeline
├[~] service aws-pcs
│ └ resources
│    └[~]  resource AWS::PCS::Cluster
├[~] service aws-pipes
│ └ resources
│    └[~]  resource AWS::Pipes::Pipe
├[~] service aws-qbusiness
│ └ resources
│    └[~]  resource AWS::QBusiness::Application
├[~] service aws-route53profiles
│ └ resources
│    └[~]  resource AWS::Route53Profiles::Profile
├[~] service aws-rum
│ └ resources
│    └[~]  resource AWS::RUM::AppMonitor
├[~] service aws-sagemaker
│ └ resources
│    └[~]  resource AWS::SageMaker::Workteam
├[~] service aws-ses
│ └ resources
│    ├[~]  resource AWS::SES::MailManagerIngressPoint
│    └[~]  resource AWS::SES::MailManagerRuleSet
├[~] service aws-shield
│ └ resources
│    └[~]  resource AWS::Shield::Protection
├[~] service aws-stepfunctions
│ └ resources
│    └[~]  resource AWS::StepFunctions::StateMachine
├[~] service aws-transfer
│ └ resources
│    └[~]  resource AWS::Transfer::Server
├[~] service aws-vpclattice
│ └ resources
│    ├[~]  resource AWS::VpcLattice::ResourceConfiguration
│    └[~]  resource AWS::VpcLattice::Service
├[~] service aws-wafv2
│ └ resources
│    └[~]  resource AWS::WAFv2::WebACL
└[~] service aws-wisdom
  └ resources
     └[~]  resource AWS::Wisdom::Assistant

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

@aws-cdk/aws-service-spec: Model database diff detected
📁 Download full diff

├[~] service aws-aps
│ └ resources
│    ├[~]  resource AWS::APS::Scraper
│    └[~]  resource AWS::APS::Workspace
├[~] service aws-b2bi
│ └ resources
│    └[~]  resource AWS::B2BI::Transformer
├[~] service aws-backupgateway
│ └ resources
│    └[~]  resource AWS::BackupGateway::Hypervisor
├[~] service aws-bedrock
│ └ resources
│    ├[~]  resource AWS::Bedrock::Agent
│    ├[~]  resource AWS::Bedrock::AgentAlias
│    ├[~]  resource AWS::Bedrock::Flow
│    └[~]  resource AWS::Bedrock::KnowledgeBase
├[~] service aws-bedrockagentcore
│ └ resources
│    ├[~]  resource AWS::BedrockAgentCore::BrowserCustom
│    ├[~]  resource AWS::BedrockAgentCore::CodeInterpreterCustom
│    ├[~]  resource AWS::BedrockAgentCore::Gateway
│    ├[~]  resource AWS::BedrockAgentCore::Memory
│    ├[~]  resource AWS::BedrockAgentCore::Runtime
│    └[~]  resource AWS::BedrockAgentCore::WorkloadIdentity
├[~] service aws-cleanrooms
│ └ resources
│    └[~]  resource AWS::CleanRooms::Membership
├[~] service aws-cloudfront
│ └ resources
│    └[~]  resource AWS::CloudFront::Distribution
├[~] service aws-cognito
│ └ resources
│    └[~]  resource AWS::Cognito::UserPool
├[~] service aws-connect
│ └ resources
│    └[~]  resource AWS::Connect::Instance
├[~] service aws-ec2
│ └ resources
│    ├[~]  resource AWS::EC2::RouteServerPeer
│    ├[~]  resource AWS::EC2::VerifiedAccessInstance
│    ├[~]  resource AWS::EC2::VPC
│    └[~]  resource AWS::EC2::VPNConnection
├[~] service aws-eks
│ └ resources
│    └[~]  resource AWS::EKS::Cluster
├[~] service aws-elasticache
│ └ resources
│    └[~]  resource AWS::ElastiCache::CacheCluster
├[~] service aws-elasticloadbalancingv2
│ └ resources
│    └[~]  resource AWS::ElasticLoadBalancingV2::LoadBalancer
├[~] service aws-entityresolution
│ └ resources
│    ├[~]  resource AWS::EntityResolution::IdMappingWorkflow
│    └[~]  resource AWS::EntityResolution::MatchingWorkflow
├[~] service aws-events
│ └ resources
│    └[~]  resource AWS::Events::EventBus
├[~] service aws-grafana
│ └ resources
│    └[~]  resource AWS::Grafana::Workspace
├[~] service aws-iotfleetwise
│ └ resources
│    ├[~]  resource AWS::IoTFleetWise::Campaign
│    └[~]  resource AWS::IoTFleetWise::Vehicle
├[~] service aws-ivschat
│ └ resources
│    └[~]  resource AWS::IVSChat::Room
├[~] service aws-kafkaconnect
│ └ resources
│    └[~]  resource AWS::KafkaConnect::Connector
├[~] service aws-m2
│ └ resources
│    └[~]  resource AWS::M2::Application
├[~] service aws-mediapackagev2
│ └ resources
│    └[~]  resource AWS::MediaPackageV2::ChannelGroup
├[~] service aws-mediatailor
│ └ resources
│    └[~]  resource AWS::MediaTailor::PlaybackConfiguration
├[~] service aws-msk
│ └ resources
│    └[~]  resource AWS::MSK::Cluster
├[~] service aws-networkfirewall
│ └ resources
│    └[~]  resource AWS::NetworkFirewall::Firewall
├[~] service aws-osis
│ └ resources
│    └[~]  resource AWS::OSIS::Pipeline
├[~] service aws-pcs
│ └ resources
│    └[~]  resource AWS::PCS::Cluster
├[~] service aws-pipes
│ └ resources
│    └[~]  resource AWS::Pipes::Pipe
├[~] service aws-qbusiness
│ └ resources
│    └[~]  resource AWS::QBusiness::Application
├[~] service aws-route53profiles
│ └ resources
│    └[~]  resource AWS::Route53Profiles::Profile
├[~] service aws-rum
│ └ resources
│    └[~]  resource AWS::RUM::AppMonitor
├[~] service aws-sagemaker
│ └ resources
│    └[~]  resource AWS::SageMaker::Workteam
├[~] service aws-ses
│ └ resources
│    ├[~]  resource AWS::SES::MailManagerIngressPoint
│    └[~]  resource AWS::SES::MailManagerRuleSet
├[~] service aws-shield
│ └ resources
│    └[~]  resource AWS::Shield::Protection
├[~] service aws-stepfunctions
│ └ resources
│    └[~]  resource AWS::StepFunctions::StateMachine
├[~] service aws-transfer
│ └ resources
│    └[~]  resource AWS::Transfer::Server
├[~] service aws-vpclattice
│ └ resources
│    ├[~]  resource AWS::VpcLattice::ResourceConfiguration
│    └[~]  resource AWS::VpcLattice::Service
├[~] service aws-wafv2
│ └ resources
│    └[~]  resource AWS::WAFv2::WebACL
└[~] service aws-wisdom
  └ resources
     └[~]  resource AWS::Wisdom::Assistant

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Dec 18, 2025
@ShadowCat567 ShadowCat567 removed the do-not-merge Do not merge this PR until further notice label Dec 18, 2025
Merged via the queue into main with commit daab9d8 Dec 18, 2025
10 of 11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the remove-old-vendedlogs-type branch December 18, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShadowCat567 @mrgrain @aws-cdk-automation