Skip to content

chore: remove vendedLogsConfig #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShadowCat567 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove vendedLogsConfig #2315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-importers/src/db-diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ export class DbDiff {
name: diffScalar(a, b, 'name'),
scrutinizable: diffScalar(a, b, 'scrutinizable'),
vendedLogs: diffField(a, b, 'vendedLogs', jsonEq),
vendedLogsConfig: diffField(a, b, 'vendedLogsConfig', jsonEq),
tagInformation: diffField(a, b, 'tagInformation', jsonEq),
primaryIdentifier: collapseEmptyDiff(
diffList(a.primaryIdentifier ?? [], b.primaryIdentifier ?? [], (x, y) => x === y),
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-importers/src/diff-fmt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ export class DiffFormatter {
listWithCaption('properties', this.renderPropertyDiff(r.properties)),
listWithCaption('attributes', this.renderPropertyDiff(r.attributes)),
listWithCaption('vendedLogs', this.renderVendedLogsArrayDiff(r.vendedLogs)),
listWithCaption('vendedLogsConfig', this.renderVendedLogsArrayDiff(r.vendedLogsConfig)),
listWithCaption(
'types',
this.renderMapDiff(
Expand Down
2 changes: 0 additions & 2 deletions packages/@aws-cdk/service-spec-importers/src/importers/import-log-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ export function importLogSources(

resource.vendedLogs ??= [];
resource.vendedLogs.push(newLog);
resource.vendedLogsConfig ??= [];
resource.vendedLogsConfig.push(newLog);
} catch (err) {
// assumes the only error we are likely to see is something relating to resource type not existing in the CFN DB
report.reportFailure(
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-types/src/types/diff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ export interface UpdatedResource {
readonly tagInformation?: ScalarDiff<Resource['tagInformation']>;
readonly scrutinizable?: ScalarDiff<Resource['scrutinizable']>;
readonly vendedLogs?: ScalarDiff<Resource['vendedLogs']>;
readonly vendedLogsConfig?: ScalarDiff<Resource['vendedLogsConfig']>;
readonly typeDefinitionDiff?: MapDiff<TypeDefinition, UpdatedTypeDefinition>;
readonly primaryIdentifier?: ListDiff<string, void>;
readonly metrics?: MapDiff<Metric, ChangedMetric>;
Expand Down
1 change: 0 additions & 1 deletion packages/@aws-cdk/service-spec-types/src/types/resource.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export interface Resource extends Entity {
arnTemplate?: string;
isStateful?: boolean;
vendedLogs?: VendedLogs[];
vendedLogsConfig?: VendedLogs[];

/**
* Information about the taggability of this resource
Expand Down
Loading