fix: Allow non-integral latency thresholds and durations #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586.
Adds the
integral: falseoption toDuration.toMillisecond()calls to allow the original non-integral/sub-millisecond threshold values to be provided to CloudWatch. These four lines are the only uses oftoMillisecondsin the package.I also created a new test for the
LatencyAlarmFactoryclass to test these specific cases. To verify that they were working, I ran the tests without the fix in place and got the expected error messages: gist.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license