-
Notifications
You must be signed in to change notification settings - Fork 89
config: add touch_on_select #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Hmm, clipserve is somewhat internal and can also be called when starting clipboard ownership. What are your thoughts on doing it from clipmenu when selecting the clip? |
In those cases, isn't the entry already on top and thus make_newest() would be a no-op? |
I was going to say we can end up racing and bumping something from another selection, but I suppose that's no worse than the current situation since post-fork execution is unbounded, so I think you're right that it doesn't matter. Maybe since "serve" is a bit internal, it should be "touch on select"? What do you think? |
WEXITSTATUS is only valid if WIFEXITED returned non-zero.
this makes an entry bump to the newest slot when it is selected via `clipmenu`.
Sounds fine to me.
Since it's called While doing that, I noticed it was using |
The CI failure seems to be unrelated? It passed earlier on my repo. |
this makes an entry bump to the newest slot when serving (e.g selecting via
clipmenu
).