Fix SyntaxError on Python 3.14 - #260
Merged
stephanlensky merged 1 commit intoJul 15, 2026
Merged
Conversation
- Remove no-op `finally: continue` that violates PEP 765. - Loop naturally continues; bare `except:` already catches all. - Fixes cdpdriver#252
jvdillon
force-pushed
the
fix/py314-finally-continue
branch
from
July 15, 2026 04:06
9ed4ec9 to
245e7f5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 765 makes control flow that exits a 'finally' block a SyntaxError in Python 3.14 (was SyntaxWarning in 3.13).
Fixes #252.
(If this PR lgty please auto-merge it.)
Description
Pre-merge Checklist
./scripts/format.shand./scripts/lint.shscripts. My code is properly formatted and has no linting errors.uv run pytestand ensured all tests pass.[Unreleased]section.