-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: add enforce strict value for combobox #5572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timarney
wants to merge
22
commits into
main
Choose a base branch
from
downshift
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
c373cbf
update package
timarney 378510e
add strict value
timarney 4064112
add checkbox to more menu
timarney 76673ad
update package
timarney b171181
add ui for builder
timarney 51609ef
hide if not combobox
timarney 1452395
add note
timarney 000d373
use type
timarney 0776cb1
Merge branch 'main' into downshift
timarney 6847883
Merge branch 'main' into downshift
timarney 698721c
Merge branch 'main' into downshift
timarney e01ab54
Merge branch 'main' into downshift
timarney 0c8bdbc
updste strings
timarney 9eeeaea
Merge branch 'main' into downshift
timarney d181cf9
Merge branch 'main' into downshift
dsamojlenko 183bdb4
Merge branch 'main' into downshift
timarney 29abe24
Merge branch 'main' into downshift
timarney c17904f
Merge branch 'main' into downshift
timarney 12baf83
Merge branch 'main' into downshift
timarney c99d789
cleanup
timarney d925584
update checkbox
timarney ef49c61
update checkbox
timarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...le]/(form administration)/form-builder/[id]/components/dialogs/MoreDialog/StrictValue.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { useTranslation } from "@i18n/client"; | ||
| import { Checkbox } from "@formBuilder/components/shared/MultipleChoice"; | ||
| import { FormElement } from "@lib/types"; | ||
|
|
||
| export const StrictValue = ({ | ||
| item, | ||
| setItem, | ||
| }: { | ||
| item: FormElement; | ||
| setItem: (item: FormElement) => void; | ||
| }) => { | ||
| const { t } = useTranslation("form-builder"); | ||
|
|
||
| // ⚠️ Early return if not combobox | ||
| if (item.type !== "combobox") { | ||
| return null; | ||
| } | ||
|
|
||
| const checked = item.properties.strictValue; | ||
|
|
||
dsamojlenko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return ( | ||
| <section className="mb-4"> | ||
| <div className="mb-2"> | ||
| <h3>{t("strictValue.title")}</h3> | ||
| </div> | ||
| <div> | ||
| <Checkbox | ||
| data-testid="strictValue" | ||
| id={`required-${item.id}-id-modal`} | ||
| value={`required-${item.id}-value-modal-` + checked} | ||
| key={`required-${item.id}-modal-` + checked} | ||
| defaultChecked={checked} | ||
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => { | ||
| setItem({ | ||
| ...item, | ||
| properties: { | ||
| ...item.properties, | ||
| strictValue: e.target.checked, | ||
| }, | ||
| }); | ||
| }} | ||
| label={t("strictValue.label")} | ||
| ></Checkbox> | ||
| </div> | ||
| </section> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1366,5 +1366,10 @@ | |
| "formDescription": "Description du formulaire" | ||
| }, | ||
| "en": "English", | ||
| "fr": "Français" | ||
| "fr": "Français", | ||
| "strictValue": { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @anikbrazeau couple of missing strings here if you get a chance |
||
| "title": "Ensure choice value", | ||
| "label": "Strict value", | ||
| "description": "strict value" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use the enum
FormElementTypes.comboboxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
000d373