Chore: Replace formBuilder.tsx with Component Model PT1 of Many #6168
Conversation
🧪 Review environmenthttps://mlw5doevmenm4zalfyvd2jzlqy0bdpzm.lambda-url.ca-central-1.on.aws/ |
ShadeWyrm
changed the title
| ? element.properties.validation.required | ||
| : false; | ||
|
|
||
| const descriptionPerLocale = element.properties[getLocalizedProperty("description", lang)]; |
There was a problem hiding this comment.
Maybe we should have helpers for pulling descriptions titles etc... ?
Just thinking about how repetitive this is going to get.
There was a problem hiding this comment.
Same with the Label, I've just been thinking through how I want to do it in case we need to break a label out of an element in other ways.
There was a problem hiding this comment.
I went with just making a linked component, but it feels a bit ugly. I'll keep thinking, and if anyone has a better idea.
| meta: { | ||
| type: FormElementTypes.textField, | ||
| }, | ||
| render({ element, lang }) { |
There was a problem hiding this comment.
Should we add a toString or renderString value ... for things like the review page / response downloads?
There was a problem hiding this comment.
Yes, did we want to make that change for this PR for textField as a proof of concept, or save it for the next one? I was going to break out validation as well.
There was a problem hiding this comment.
We can save it for the next one :)
…y Formik to instead.
…hange as expected.
A refactor of the formBuilder.tsx to adopt a component model with the final intent being components (eg: TextField, Checkbox, AddressComplete, FileInput, etc...) are fully self contained, and logic is not spread across the application.
This PR only implements the TextField component so that it can be tested heavily, and then a new PR can be span up for other components in parallel.