Implement Request.Equal() method#112
Merged
patjakdev merged 3 commits intocedar-policy:mainfrom Oct 28, 2025
Merged
Conversation
philhassey
reviewed
Oct 20, 2025
types/authorize_test.go
Outdated
| for j, s := range testcases[:i] { | ||
| expected := i == j | ||
| actual := r.Equal(s) | ||
| if actual != s.Equal(r) { |
Contributor
There was a problem hiding this comment.
It might be nice if instead of running the testcases against the testcases, to have specific left/right and expected equality values. (Then you could check the equality values using testutil.Equals)
Contributor
There was a problem hiding this comment.
e.g. struct {
left Request
right Request
want bool
}
philhassey
previously requested changes
Oct 20, 2025
Contributor
philhassey
left a comment
philhassey
left a comment
There was a problem hiding this comment.
Looks good, just a minor improvement to the test structure would be nice.
Contributor
|
Sorry for the delay in feedback here, notifications weren't set up right. |
Contributor
|
@gregory-nisbet Also there's some lint complaints: 
|
gregory-nisbet
force-pushed
the
2025-10-07-add-request-equal
branch
from
9abb4f9 to
f623698
Compare
Implement Request.Equal(), include a basic check that it's working correctly, and check that cmp.Diff can consume two requests and compare them. Signed-off-by: Greg NISBET <gregory.nisbet@gmail.com>
Signed-off-by: Greg NISBET <gregory.nisbet@gmail.com>
Signed-off-by: Greg NISBET <gregory.nisbet@gmail.com>
gregory-nisbet
force-pushed
the
2025-10-07-add-request-equal
branch
from
9b256c2 to
73efbdc
Compare
patjakdev
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Request.Equal(), include a basic check that it's working correctly, and check that cmp.Diff can consume two requests and compare them.
Issue #, if available:
#107
Description of changes:
Adds Request.Equal and some tests.