Skip to content

types: add Entity.Equal() implementation#93

Merged
patjakdev merged 1 commit intocedar-policy:mainfrom
strongdm:patjak/add-entity-equal
Jun 18, 2025
Merged

types: add Entity.Equal() implementation#93
patjakdev merged 1 commit intocedar-policy:mainfrom
strongdm:patjak/add-entity-equal

Conversation

@patjakdev
Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:

Having an implementation of Equal() adds a canonical method of checking for Entity equality and makes it compatible with the cmp package's Equal() function and other types in this package (e.g. Record, EntityUID).

@patjakdev patjakdev marked this pull request as ready for review June 18, 2025 23:35
@patjakdev patjakdev requested a review from philhassey June 18, 2025 23:35
Copy link
Copy Markdown
Contributor

@philhassey philhassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

Having an implementation of Equal() adds a canonical method of checking for Entity equality and makes it compatible with the cmp package's [Equal()](https://pkg.go.dev/github.com/google/go-cmp/cmp#Equal) function and other types in this package (e.g. Record, EntityUID).

Signed-off-by: Patrick Jakubowski <patrick.jakubowski@strongdm.com>
@patjakdev patjakdev force-pushed the patjak/add-entity-equal branch from b053f42 to be5fd82 Compare June 18, 2025 23:40
@patjakdev patjakdev merged commit b84f731 into cedar-policy:main Jun 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants