Skip to content

cedar-go: ignore var-naming revive lint errors in the types package#95

Merged
philhassey merged 2 commits intocedar-policy:mainfrom
strongdm:ignore-var-naming
Jul 1, 2025
Merged

cedar-go: ignore var-naming revive lint errors in the types package#95
philhassey merged 2 commits intocedar-policy:mainfrom
strongdm:ignore-var-naming

Conversation

@philhassey
Copy link
Copy Markdown
Contributor

Addresses #94

A change in the linters is blocking a contributor's PR.

Addresses cedar-policy#94

Signed-off-by: philhassey <phil@strongdm.com>
@philhassey philhassey requested review from Copilot and patjakdev July 1, 2025 20:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GolangCI configuration to suppress revive’s var-naming linter errors in the types/ package, allowing intentional naming patterns there.

  • Add an exclude rule for revive’s var-naming check scoped to types/
Comments suppressed due to low confidence (1)

.golangci.yml:37

  • Exclude-rules path fields are treated as regex. Consider anchoring the pattern (e.g., ^types/ or ^types/.*\\.go$) to avoid accidentally matching other paths.
      - path: types/

Copy link
Copy Markdown
Collaborator

@patjakdev patjakdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can be more specific about disabling just the package name checks like this:

  settings:
    revive:
      rules:
        - name: var-naming
          arguments:
            - []
            - []
            - - skip-package-name-checks: true

Addresses cedar-policy#94

Signed-off-by: philhassey <phil@strongdm.com>
@philhassey philhassey merged commit ccdc86f into cedar-policy:main Jul 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants