cedar-go: ignore var-naming revive lint errors in the types package#95
Merged
philhassey merged 2 commits intocedar-policy:mainfrom Jul 1, 2025
Merged
cedar-go: ignore var-naming revive lint errors in the types package#95philhassey merged 2 commits intocedar-policy:mainfrom
philhassey merged 2 commits intocedar-policy:mainfrom
Conversation
Addresses cedar-policy#94 Signed-off-by: philhassey <phil@strongdm.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GolangCI configuration to suppress revive’s var-naming linter errors in the types/ package, allowing intentional naming patterns there.
- Add an exclude rule for
revive’svar-namingcheck scoped totypes/
Comments suppressed due to low confidence (1)
.golangci.yml:37
- Exclude-rules
pathfields are treated as regex. Consider anchoring the pattern (e.g.,^types/or^types/.*\\.go$) to avoid accidentally matching other paths.
- path: types/
patjakdev
reviewed
Jul 1, 2025
Collaborator
patjakdev
left a comment
There was a problem hiding this comment.
We can be more specific about disabling just the package name checks like this:
settings:
revive:
rules:
- name: var-naming
arguments:
- []
- []
- - skip-package-name-checks: true
Addresses cedar-policy#94 Signed-off-by: philhassey <phil@strongdm.com>
patjakdev
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #94
A change in the linters is blocking a contributor's PR.