Fixing several issues #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new fucntion libswd_log_flush() which will log and then flush the stdout. Function is used in libswd_memap.c for speed logging.
Fixed all =+ with +=.
Createt a new struct libswd_stats_t for cmdqlen which is used for memory limitation management in function libswd_cmd_enqueue(...). CMD queue len is configured by maxcmdqlen and all libswd_cmdq_... functions handles correctly cmdqlen. It was necessary for function parameter changes. Solution with counting directly from queue chain is unacceptable for embedded platform. Found a bug at libswd_deinit(...), there is no memory free for libswdctx->driver. Maybe an improvement for libswd_cmdq_append(...) which could make a queue startpoint automatically. Let the autor decide.
|
Yea, this is it! Each functional update in a separate commit :-) Why do you define |
|
Why do you define libswd_log_flush() in two places?
What is the reason to use attribute ((weak))?
|
- Added new CPUID for ARM Cortex-M3 r2p0 0x412FC230 - Added lines for storing CPUID init results into libswdctx->log.debug.cpuid...
- Added new CPUID for ARM Cortex-M7
- libswd_error.c is not counting with memory limitation by stats, thus implemented a minimum handling. TODO: libswd_error.c should be revised and repaired, see TODO comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cederom ,
here are the separated commits for reported issues. The last commit is about to discuss a little bit. See comments in code at last commit :)
Regards,
Tomas Kamenicky