Fix Symfony 7.4 Request::get() deprecation in scopeFilteredByRequest#156
Open
jensbaagaard wants to merge 1 commit into
Open
Fix Symfony 7.4 Request::get() deprecation in scopeFilteredByRequest#156jensbaagaard wants to merge 1 commit into
jensbaagaard wants to merge 1 commit into
Conversation
Replace $request->get(...) with $request->query(...) in the request-insurances admin index filter scope. Symfony 7.4 deprecates Request::get() because of its ambiguous lookup order across attributes/query/request bags. The admin filter form is a GET form, so query() is the precise replacement. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$request->get(...)with$request->query(...)inRequestInsurance::scopeFilteredByRequest()(the admin index filter scope).query()is the precise, behavior-preserving replacement (previouslyget()would also fall back toattributesandrequestbody, neither of which carry these inputs).Why
Symfony deprecated
Request::get()because of its ambiguous lookup order acrossattributes,query, thenrequestbags — a long-standing source of subtle bugs. Pickingquery()here narrows the lookup to query-string params, which is what the form actually sends.Test plan
🤖 Generated with Claude Code