Skip to content

Reconnect the database after any failed worker cycle #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LauJosefsen merged 1 commit into from
Aug 6, 2026
Merged

Reconnect the database after any failed worker cycle #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions src/RequestInsurance/RequestInsuranceWorker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,29 +139,29 @@ public function run(bool $runOnlyOnce = false): void
*/
protected function handleCycleFailure(Throwable $throwable): void
{
if ( ! $this->wasCausedByLostConnection($throwable)) {
if ($this->wasCausedByLostConnection($throwable)) {
$this->consecutiveLostConnections++;

$message = sprintf(
'RequestInsurance Worker (#%s) lost its database connection during %s and is reconnecting (%d in a row)',
$this->runningHash,
$this->currentPhase,
$this->consecutiveLostConnections
);

if ($this->consecutiveLostConnections > self::QUIET_LOST_CONNECTION_RECOVERIES) {
Log::error($message, ['exception' => $throwable]);
} else {
Log::debug($message);
}
} else {
$this->consecutiveLostConnections = 0;

Log::error($throwable);

return;
}

$this->consecutiveLostConnections++;

$message = sprintf(
'RequestInsurance Worker (#%s) lost its database connection during %s and is reconnecting (%d in a row)',
$this->runningHash,
$this->currentPhase,
$this->consecutiveLostConnections
);

if ($this->consecutiveLostConnections > self::QUIET_LOST_CONNECTION_RECOVERIES) {
Log::error($message, ['exception' => $throwable]);
} else {
Log::debug($message);
}

// The connection is given up on no matter what failed the cycle, since a failure can leave it in a
// state it never recovers from on its own, such as a transaction its driver still considers open.
rescue(fn () => $this->reconnectToDatabase(), null, false);
}

Expand Down
16 changes: 15 additions & 1 deletion tests/Unit/RequestInsuranceWorkerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Exception;
use Throwable;
use PDOException;
use Tests\TestCase;
use GuzzleHttp\Psr7\Request;
use Illuminate\Support\Facades\Log;
Expand Down Expand Up @@ -501,7 +502,20 @@ public function test_it_reports_cycle_failures_that_are_not_lost_connections():

$worker->exposeReportCycleFailure($throwable);

$this->assertSame(0, $worker->reconnects);
$this->assertSame(1, $worker->reconnects);
}

public function test_it_gives_up_on_a_connection_holding_a_stranded_transaction(): void
{
$worker = $this->getWorkerProbe();

Log::shouldReceive('error')->times(5);

foreach (range(1, 5) as $ignored) {
$worker->exposeReportCycleFailure(new PDOException('There is already an active transaction'));
}

$this->assertSame(5, $worker->reconnects);
}

/**
Expand Down
Loading