Fix YAML schema inconsistencies - #128
Merged
Merged
Conversation
- examples: stop_grace_period was 10 (= 10ns); change to 10000000000 with "10s (nanoseconds)" comment to match the convention #109 established for health_check durations. - mounts.readonly -> mounts.read_only for snake_case consistency with the rest of the schema and Docker Compose. BREAKING. - Configs File.Mode 0 -> 0o444 to match Docker Compose's default for config file permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three schema-vs-mapping inconsistencies surfaced while reviewing #127.
examples/swarm-app.yml:stop_grace_period: 10was 10ns. Bumped to10000000000 # 10s (nanoseconds)to match the convention Fix health_check duration types and example values #109 established forhealth_checkdurations.mounts.readonly→mounts.read_only— every other multi-word field in the schema is snake_case (stop_signal,target_port,start_interval, …);readonlywas the only outlier. Docker Compose itself usesread_only. Breaking for any consumer still onreadonly:.ConfigReference.File.Modewas hardcoded to0(=chmod 000). Set to0o444to match Docker Compose's documented default. Existing deployments will show a one-time diff until redeployed.Test plan
tsccleaneslint .cleanjestpasses