Repository navigation
Reuse initialized cel.Env across fuzz iterations in fuzzing - #1606
Merged
Merged
Conversation
- Cache `getCELFuzzEnv` using `sync.OnceValues` so `FuzzParser`, `FuzzChecker`, `FuzzCompile`, `FuzzInterpreter`, and `FuzzEval` reuse the initialized `*cel.Env` instead of rebuilding standard library declarations, type registries, and parser options on every fuzz input (cel-expr#1592). - Hoist `getCELFuzzEnv()` outside the per-input closure in `FuzzParser`, add regression seed inputs, and add `BenchmarkFuzzParserIter`. Benchmarks (`go test -bench=^BenchmarkFuzzParserIter$ -benchmem`): goos: linux goarch: amd64 pkg: cel.dev/cel-go/fuzzing cpu: Intel(R) Xeon(R) CPU @ 2.20GHz │ before.txt │ after.txt │ │ sec/op │ sec/op vs base │ FuzzParserIter-8 7.567µ ± 14% 2.614µ ± 7% -65.46% (p=0.002 n=6) │ before.txt │ after.txt │ │ B/op │ B/op vs base │ FuzzParserIter-8 2.954Ki ± 0% 1.211Ki ± 0% -59.01% (p=0.002 n=6) │ before.txt │ after.txt │ │ allocs/op │ allocs/op vs base │ FuzzParserIter-8 61.00 ± 0% 31.00 ± 0% -49.18% (p=0.002 n=6)
TristonianJones
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getCELFuzzEnvusingsync.OnceValuessoFuzzParser,FuzzChecker,FuzzCompile,FuzzInterpreter, andFuzzEvalreuse the initialized*cel.Envinstead of rebuilding standard library declarations, type registries, and parser options on every fuzz input (OSS-Fuzz issue 578817974 #1592).getCELFuzzEnv()outside the per-input closure inFuzzParser, add regression seed inputs, and addBenchmarkFuzzParserIter.Benchmarks (
go test -bench=^BenchmarkFuzzParserIter$ -benchmem)goos: linux·goarch: amd64·pkg: cel.dev/cel-go/fuzzing·cpu: Intel(R) Xeon(R) CPU @ 2.20GHzbefore.txt(sec/op)after.txt(sec/op)FuzzParserIter-8before.txt(B/op)after.txt(B/op)FuzzParserIter-8before.txt(allocs/op)after.txt(allocs/op)FuzzParserIter-8