Reconstruct additional data in G4Track #1835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
bug
Test summary 4 490 files 6 855 suites 13m 39s ⏱️ Results for commit 04dc5d3. ♻️ This comment has been updated with latest results. |
esseivaju
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1756 is crashing due to a null pointer: @rahmans1 and I tracked it down to
G4Track::GetMaterialCutsCouplewhich actually points to the step:fpStep->GetPreStepPoint()->GetMaterialCutsCouple();. There are circular dependencies between Step and Track and a lot of duplicate data between the three.This should fix the crash by setting the track's step pointer during construction.