Fix document warnings related CI infrastructure #2148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethrj
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2148 +/- ##
=========================================
Coverage 84.89% 84.90%
=========================================
Files 1273 1273
Lines 44667 44667
Branches 16765 16611 -154
=========================================
+ Hits 37922 37924 +2
+ Misses 4933 4758 -175
- Partials 1812 1985 +173 🚀 New features to boost your workflow:
|
Test summary 5 726 files 9 212 suites 17m 56s ⏱️ Results for commit 2b62f87. ♻️ This comment has been updated with latest results. |
…disable device debug" This reverts commit 3b81610. We've got vecgeom built against 70, and it seems that the build time increased drastically as a result of that or virtual. Testing independently, it seems there is little to no difference for omitting the real architecture.
Contributor
Why is it now unnecessary? (The linked issue is not explicitly marked resolved). |
Member
Author
|
@pcanal The issue I posted was primarily because of a bug in Git that was present for one minor patch version that seems to have been quickly fixed and deployed to the latest github runners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings in the sphinx documentation were accidentally disabled in (I think) #1988 because warnings are now shown during doctree generation rather than html construction. I fixed the couple errors in the docs that have accumulated during that time.
Related, I've removed a now-unnecessary workaround for actions/checkout#2041 , and I've added code to get the build size and clean the build directory after it's last used, since we now seem to see intermittent failures on the CUDA builds https://github.com/celeritas-project/celeritas/actions/runs/19948559972/job/57204118695 .
To fix the size overrun errors (nearly 5GB for the debug/reldeb) I've disabled CUBIN compilation for the reldeb case and turned off DEVICE_DEBUG for the debug case.