Skip to content

Conversation

@sethrj
Copy link
Member

@sethrj sethrj commented Dec 9, 2025

This fixes a couple of minor build errors needed to build Celeritas against the larsoft toolchain. It adds a somewhat complicated scisoftbuild01.sh that loads the basic environments for running inside an apptainer:

  • Sets up DUNE UPS with setup_dune.sh
  • Sets up larsoft development with setup larsoft ...
  • Creates an MRB dev environment with mrb newDev
  • Activates the environement with . .../setup
  • Clones larg4 with mrb g
  • Loads CMake and other larg4 dependencies with mrbsetenv
# Set up scratch directory on bare metal
. scripts/env/scisoftbuild01.sh
# Start apptainer, forwarding necessary directories
/cvmfs/oasis.opensciencegrid.org/mis/apptainer/current/bin/apptainer \
  shell --shell=/bin/bash \
  -B /cvmfs,$SCRATCHDIR,$HOME,$XDG_RUNTIME_DIR,/opt,/etc/hostname,/etc/hosts,/etc/krb5.conf  \
  --ipc --pid  \
  /cvmfs/singularity.opensciencegrid.org/fermilab/fnal-dev-sl7:latest

@sethrj sethrj requested a review from esseivaju as a code owner December 9, 2025 15:35
@sethrj sethrj added core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes labels Dec 9, 2025
This commit means that you must (please!) install pre-commit
on your development machine and run `pre-commit install --install-hooks`.
For more information, see
https://celeritas-project.github.io/celeritas/user/development/style.html#formatting

Autogenerated: https://pre-commit.ci
@pcanal
Copy link
Contributor

pcanal commented Dec 9, 2025

It adds a somewhat complicated scisoftbuild01.sh that loads the basic environments for running inside an apptainer:

Should the bullets be copy/pasted in script's header as summary/documentation?

Set up scratch directory on bare metal

Shouldn't this be somewhere in the repository? Either in a .md or maybe the new script's header?

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.90%. Comparing base (84a24a8) to head (6e807ed).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2153   +/-   ##
========================================
  Coverage    84.90%   84.90%           
========================================
  Files         1273     1273           
  Lines        44667    44668    +1     
  Branches     16611    16611           
========================================
+ Hits         37925    37926    +1     
- Misses        4756     4758    +2     
+ Partials      1986     1984    -2     
Files with missing lines Coverage Δ
src/corecel/sys/ScopedSignalHandler.cc 89.47% <100.00%> (+0.18%) ⬆️
src/geocel/ScopedGeantLogger.cc 90.47% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Test summary

 5 730 files   9 216 suites   17m 53s ⏱️
 2 078 tests  2 052 ✅  26 💤 0 ❌
32 038 runs  31 909 ✅ 129 💤 0 ❌

Results for commit 6e807ed.

♻️ This comment has been updated with latest results.

Copy link
Member

@stognini stognini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sethrj sethrj merged commit 93c89d0 into celeritas-project:develop Dec 10, 2025
44 checks passed
@sethrj sethrj deleted the larsoft-env branch December 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Software engineering infrastructure (corecel) minor Refactoring or minor internal changes/fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants