-
Notifications
You must be signed in to change notification settings - Fork 45
Support builds on fnal-dev-sl7 on scisoftbuild01 #2153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit means that you must (please!) install pre-commit on your development machine and run `pre-commit install --install-hooks`. For more information, see https://celeritas-project.github.io/celeritas/user/development/style.html#formatting Autogenerated: https://pre-commit.ci
Should the bullets be copy/pasted in script's header as summary/documentation?
Shouldn't this be somewhere in the repository? Either in a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2153 +/- ##
========================================
Coverage 84.90% 84.90%
========================================
Files 1273 1273
Lines 44667 44668 +1
Branches 16611 16611
========================================
+ Hits 37925 37926 +1
- Misses 4756 4758 +2
+ Partials 1986 1984 -2
🚀 New features to boost your workflow:
|
Test summary 5 730 files 9 216 suites 17m 53s ⏱️ Results for commit 6e807ed. ♻️ This comment has been updated with latest results. |
stognini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This fixes a couple of minor build errors needed to build Celeritas against the larsoft toolchain. It adds a somewhat complicated
scisoftbuild01.shthat loads the basic environments for running inside an apptainer:setup_dune.shsetup larsoft ...mrb newDev. .../setupmrb gmrbsetenv