pre-commit: Add ruff rules for unsafe naive datetimes - #1060
Open
cclauss wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 87.90% 87.90%
=======================================
Files 32 32
Lines 1025 1025
Branches 84 84
=======================================
Hits 901 901
Misses 106 106
Partials 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alirafiei75
reviewed
Jul 3, 2026
alirafiei75
approved these changes
Jul 3, 2026
auvipy
reviewed
Jul 4, 2026
| def schedule(self): | ||
| initial = update = False | ||
| current_time = datetime.datetime.now() | ||
| current_time = aware_now() |
Member
There was a problem hiding this comment.
I think this change and the one above demands unit tests for verification. @alirafiei75 what do you think?
Contributor
There was a problem hiding this comment.
I do not think that is critical because both of the changes do not make any logical difference and there are already unit tests on the function. but it wouldn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1059
Lint rules to ban the usage of unsafe
naive datetimes.%
ruff check --select=DTZ --statisticsRelated to: