CIP-31: updates according to the implemention #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
reviewed
Apr 7, 2025
tac0turtle
force-pushed
the
marko/cip-31_update
branch
from
5dbfe08 to
e955733
Compare
rootulp
reviewed
Apr 8, 2025
cmwaters
reviewed
Apr 8, 2025
There was a problem hiding this comment.
Thanks for the examples - they help explain how claiming works a lot.
I actually have a follow up question targeting the commission cap:
- Validators that currently have a commission of 100% won't have their commission affected right - just new validators.
- What about validators that change their commission? They won't be able to update their validator to a commission that is beyond the 25%. Is this reflected in the PR?
cips/cip-031.md
Outdated
Comment on lines
99
to
105
| ### Periodic Vesting Accounts | ||
|
|
||
| ``` | ||
| Periodic account creation will be removed, and update schedule will be a noop | ||
|
|
||
| ### Permanent Vesting Accounts | ||
|
|
||
| Permanent account creation will be removed, and update schedule will be a noop |
There was a problem hiding this comment.
Are we actually removing these types of vesting accounts or do they simply not apply to the new staking rules?
There was a problem hiding this comment.
We're not removing them. We're disabling the ability to create new periodic or permanent vesting accounts but existing accounts will remain. The existing accounts will not apply have CIP-31 applied to them.
That is not reflected. I added a sentence on this in the latest commit |
rootulp
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr updates the cip-31 guidelines and implementation in order to make the design and flow as simple as possible.
closes #284