-
Notifications
You must be signed in to change notification settings - Fork 52
chore: adjust to year 1.75 #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refining the documentation for Celestia Improvement Proposal (CIP) 029. The core intent is to clarify the illustrative timeline for the proposed inflation and disinflation adjustments within the network's economic model, ensuring the documentation accurately reflects the intended schedule. Additionally, it includes minor textual and formatting improvements for better readability.
Highlights
- CIP-029 Documentation Update: The primary change in this pull request is an update to
cips/cip-029.md, which details a proposal to decrease inflation and disinflation. Specifically, the illustrative timing for the proposed inflation rate reduction within the economic model's tables and descriptions has been adjusted from 'year 1.5' to 'year 1.75'. - Minor Formatting and Typo Fixes: Several minor cosmetic changes were applied across the document, including correcting a double space typo, standardizing list item formatting from asterisks to hyphens, and adjusting table header formatting for consistency. An italicized word was also updated for correct Markdown rendering.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CIP-29 document to adjust a timeline reference from 'year 1.5' to 'year 1.75', along with several formatting improvements and typo fixes throughout the markdown file. The changes are consistent and improve the document's quality. I have one suggestion to improve the clarity of a note in one of the tables to ensure it's unambiguous.
Overview
Resolves #334