Skip to content

Conversation

@evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Jul 25, 2025

Overview

adds the meta CIP for the matcha upgrade

blocked on #337

For editors

  • assign CIP number, rename file
  • add to README.md - to include on homepage
  • add to SUMMARY.md - to render on site

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @evan-forbes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new meta-CIP (CIP-041) that formally defines the 'Matcha Network Upgrade'. This CIP serves as a central reference point, consolidating and listing all the individual state-breaking CIPs that are part of this significant network upgrade. Its purpose is to provide a clear, comprehensive overview of the changes encompassed by the Matcha upgrade.

Highlights

  • New Meta-CIP (CIP-041): I've added a new document, CIP-041, which serves as a meta-CIP specifically for the upcoming 'Matcha Network Upgrade'. This CIP acts as a central reference point for all changes included in this upgrade.
  • Matcha Network Upgrade Scope: This meta-CIP explicitly lists and references five individual state-breaking CIPs (CIP-36, CIP-37, CIP-38, CIP-39, and CIP-40) that collectively constitute the Matcha Network Upgrade. It clarifies that all these changes necessitate a breaking network upgrade.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces CIP-041, a meta-CIP for the Matcha network upgrade. The new document is well-structured and clearly lists the constituent CIPs for the upgrade. My review focuses on ensuring the new document adheres to the repository's formatting conventions and templates. I've suggested a few minor changes to improve consistency, such as updating the author and description format, providing a more specific discussions-to link, and adding a newline at the end of the file.

cips/cip-041.md Outdated
| cip | 41 |
|--------------------|------------------------------------------------------------------------------------------------|
| title | Matcha Network Upgrade |
| description | Reference specifications included in the Matcha Network Upgrade |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the cip-template.md, the description field should contain a full, short sentence. The current description is a sentence fragment. Making this a complete sentence would improve consistency with the template.

Suggested change
| description | Reference specifications included in the Matcha Network Upgrade |
| description | This CIP provides reference specifications included in the Matcha Network Upgrade. |

cips/cip-041.md Outdated
|--------------------|------------------------------------------------------------------------------------------------|
| title | Matcha Network Upgrade |
| description | Reference specifications included in the Matcha Network Upgrade |
| author | [@evan-forbes](https://github.com/evan-forbes) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The format for the author field doesn't align with the convention specified in cip-template.md and seen in other recent CIPs (e.g., CIP-38, CIP-39). The template suggests the format FirstName LastName ([@GitHubUsername](...)). Including the author's full name would improve consistency.

Suggested change
| author | [@evan-forbes](https://github.com/evan-forbes) |
| author | Evan Forbes ([@evan-forbes](https://github.com/evan-forbes)) |

cips/cip-041.md Outdated
| title | Matcha Network Upgrade |
| description | Reference specifications included in the Matcha Network Upgrade |
| author | [@evan-forbes](https://github.com/evan-forbes) |
| discussions-to | <https://forum.celestia.org> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The discussions-to link points to the generic Celestia forum homepage. For better traceability and to centralize the conversation, this should point to a specific forum post dedicated to the Matcha network upgrade. This is a common convention in other CIPs within this repository.

Suggested change
| discussions-to | <https://forum.celestia.org> |
| discussions-to | <https://forum.celestia.org/t/matcha-network-upgrade/XXXX> |

@cmwaters
Copy link
Collaborator

@evan-forbes just FYI, the convention I've noticed in the past is that CIP submitters don't assign the CIP number. That is done by the reviewers. Not that we can't change it if we feel the convention isn't necessary

@jcstein jcstein requested review from cmwaters, ebuchman and rootulp July 28, 2025 12:58
@jcstein jcstein self-requested a review July 28, 2025 13:11
@jcstein jcstein changed the title docs: add CIP-041 docs: add CIP-Matcha Network Upgrade Jul 28, 2025
@cmwaters
Copy link
Collaborator

cmwaters commented Aug 1, 2025

@evan-forbes do you want to update this and include the reduced inflation CIP?

@jcstein
Copy link
Member

jcstein commented Aug 8, 2025

is this ready for review @evan-forbes ?

@evan-forbes evan-forbes marked this pull request as ready for review August 11, 2025 18:44
@evan-forbes
Copy link
Member Author

just updated @jcstein note I removed the CIP number and file name as to avoid picking one prematurely per req, so that will have to be changed

@jcstein jcstein merged commit 533a133 into celestiaorg:main Aug 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants