-
Notifications
You must be signed in to change notification settings - Fork 52
CIP to reduce issuance #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cmwaters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new Celestia Improvement Proposal (CIP) aimed at significantly adjusting the network's economic parameters. The core objective is to reduce the overall issuance of TIA tokens by halving the inflation rate, while simultaneously increasing the minimum commission for validators. These changes are designed to enhance TIA's suitability for financial applications by lowering the opportunity cost of holding the token, ensuring validator sustainability, and maintaining the network's long-term disinflationary trajectory.
Highlights
- Inflation Rate Reduction: The proposal halves the Celestia network's inflation rate from 5% to 2.5%, effective in the upcoming v5 major upgrade. This aims to make TIA more suitable for financial applications by reducing the opportunity cost of using it as collateral or in DeFi protocols.
- Minimum Validator Commission Increase: The minimum commission rate for validators is proposed to double from 5% to 10%. This change is intended to balance the reduced overall issuance and ensure validators remain adequately compensated for their services, maintaining their revenue at current levels.
- Economic Impact Analysis: The CIP includes detailed tables analyzing the impact of these proposed changes on Total Staking APR, Delegator APR, and Validator APR across various bonding ratios, providing a clear picture of the expected yield shifts.
- Security Considerations: The proposal addresses potential security implications, specifically concerning validator incentives and the possible impact of lower staking yields on the network's bonded ratio, which could affect network security if it falls below safe thresholds.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a Celestia Improvement Proposal (CIP) to reduce the network's inflation rate and increase the minimum validator commission. The proposal is well-structured and provides a clear rationale and analysis of the impacts. My review focuses on improving the clarity, correctness, and completeness of the proposal document. Key suggestions include clarifying the timeline in the inflation schedule, fixing typos, and adding important details to the specification regarding validator commission adjustments.
| | Year | Current Inflation (5%) | Proposed Inflation (2.5%) | Notes | | ||
| |------|------------------------|-------------------------|-------| | ||
| | **0** | 8.00% | 8.00% | Genesis year, no change | | ||
| | **1** | 7.20% | 7.20% | | | ||
| | **v4** | 5.00% | 5.00% | After CIP-29 reduction | | ||
| | **v5** | 4.67% | 2.50% | **Proposed CIP** | | ||
| | **2** | 4.35% | 2.33% | Regular annual disinflation applied (6.7%) | | ||
| | **3** | 4.06% | 2.17% | Regular annual disinflation applied (6.7%) | | ||
| | **4** | 3.79% | 2.02% | Regular annual disinflation applied (6.7%) | | ||
| | **5** | 3.54% | 1.88% | Regular annual disinflation applied (6.7%) | | ||
| | **6** | 3.30% | 1.75% | Regular annual disinflation applied (6.7%) | | ||
| | **7** | 3.08% | 1.63% | Regular annual disinflation applied (6.7%) | | ||
| | **8** | 2.87% | 1.52% | Regular annual disinflation applied (6.7%) | | ||
| | **9** | 2.68% | 1.50% | Target inflation reached | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[optional] CIP-29 has this table:
Lines 45 to 66 in ab63f71
| | Year | Original Inflation | New Adjusted Inflation | Notes | | |
| | -------: | -----------------: | ---------------------: | :--------------------------------------------------------------------------------------------------------------------------------- | | |
| | **0** | 8.00 | 8.00 | Genesis year, no change. | | |
| | **1** | 7.20 | 7.20 | | | |
| | **1.75** | 7.20 | 5.00088 | Reduce year 0 inflation by 33% and additionally apply 6.7% disinflation, lowering the inflation rate to 5.00088% | | |
| | **2** | 6.48 | 4.66582 | Regular annual disinflation applied (6.7%). | | |
| | **3** | 5.83 | 4.35321 | Regular annual disinflation applied (6.7%). | | |
| | **4** | 5.25 | 4.06155 | Regular annual disinflation applied (6.7%). | | |
| | **5** | 4.72 | 3.78942 | Regular annual disinflation applied (6.7%). | | |
| | **6** | 4.25 | 3.53553 | Regular annual disinflation applied (6.7%). | | |
| | **7** | 3.83 | 3.29865 | Regular annual disinflation applied (6.7%). | | |
| | **8** | 3.44 | 3.07764 | Regular annual disinflation applied (6.7%). | | |
| | **9** | 3.10 | 2.87144 | Regular annual disinflation applied (6.7%). | | |
| | **10** | 2.79 | 2.67905 | Regular annual disinflation applied (6.7%). | | |
| | **11** | 2.51 | 2.49956 | Regular annual disinflation applied (6.7%). | | |
| | **12** | 2.26 | 2.33209 | Regular annual disinflation applied (6.7%). | | |
| | **13** | 2.03 | 2.17584 | Regular annual disinflation applied (6.7%). | | |
| | **14** | 1.83 | 2.03005 | Regular annual disinflation applied (6.7%). | | |
| | **15** | 1.65 | 1.89404 | Regular annual disinflation applied (6.7%). | | |
| | **16** | 1.50 | 1.76714 | Regular annual disinflation applied (6.7%). | | |
| | **17** | 1.50 | 1.64874 | Regular annual disinflation applied (6.7%). | | |
| | **18** | 1.50 | 1.53828 | Regular annual disinflation applied (6.7%). | |
- Can the table in this PR expand to 18 or 20 years?
- [optional] is it worth expanding the decimal places so that the current inflation in this table matches the proposed inflation from the previous table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should extend, too. 20 seems safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think extending decimals also makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But nothing else happens after year 9. There's no new information to convey when target inflation is reached
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, true..good on that front. wdyt about decimals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, good point. Reducing the initial inflation by 50% means it takes like ~10 fewer years to reach the target inflation of 1.5%
Co-authored-by: Rootul P <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jcstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aside from open comment on tables
…elestiaorg#337) Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Callum Waters <[email protected]> Co-authored-by: Josh Stein <[email protected]> Co-authored-by: CHAMI Rachid <[email protected]>
|
Is this CIP meant to finish off the remaining validators? |
|
Currently, a validator earns approximately $4,108 per month with a 10% commission, 3 million TIA delegated, a token price of $1.6, and an APR of 10.27%. We are aware that in the coming month, 43.5 million TIA purchased from Polychain will return to staking, which will increase the staking ratio to ~51.4% and reduce the APR to ~9.72%, bringing validator earnings down to approximately $3,888 per month. Validators must cover the costs of bare-metal servers, monitoring systems, IBC relayers, backup nodes, alerting systems, key management, and security infrastructure. To maintain decentralization, many operators choose to run infrastructure in geographically diverse and less common data centers, which significantly increases expenses. At current levels, profitability is already near the margin. If the inflation is reduced to 2.5%, with the same staking ratio, the APR would drop to ~4.86%, resulting in validator income of only ~$1,944 per month — half the current level. In such conditions, many validators will be forced to abandon high-quality infrastructure in favor of cheaper cloud setups, which could compromise the reliability and decentralization of the network. Furthermore, in the recent forum discussion Proof of Governance as the endgame for LSTs, Adlerjohn emphasizes the importance of maintaining validator incentives, as a key factor in ensuring network security. Sustaining adequate validator income is not just an economic issue — it’s fundamental to the security and robustness of consensus. Reducing inflation month after month is not a sustainable strategy. It might make sense under different market conditions, but certainly not right now, when the network is still growing and infrastructure costs remain high. We believe this proposal does not represent an improvement and that changes to inflation must be considered more cautiously, with long-term validator sustainability in mind. |
Proposes changes to the protocol that would halve issuance from 5% in v4 to 2.5% in v5 and double minimum commission from 5% to 10%
For editors