chore: move CIP-35 Header Pruning for Light Nodes to Final #344
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the status of CIP-35, which details the header pruning mechanism for light nodes, from "Last Call" to "Final". This change reflects the official acceptance of the proposal, marking it as a finalized standard within the Celestia ecosystem.
Highlights
- CIP-35 Status Update: The status of CIP-35, which outlines the "Header Pruning for Light Nodes" mechanism, has been updated from "Last Call" to "Final". This change signifies the official acceptance and finalization of the proposal as a standard.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly moves CIP-35 to 'Final' status by updating the status field and removing the last-call-deadline, which aligns with the process outlined in CIP-1. The change is purely procedural as expected for this transition.
While reviewing the full document for context, I noticed a minor inconsistency in cips/cip-035.md. Line 61 refers to CIP-034 for the SamplingWindow definition, but CIP-034 itself points to CIP-036 for this definition. Since this document is being finalized, it would be good to ensure all references are accurate. This could be addressed in a follow-up PR as an errata correction, as per the CIP process. I'm mentioning it here for awareness as it's outside the lines changed in this PR.
Overview