-
Notifications
You must be signed in to change notification settings - Fork 52
chore: move CIP 40 to last call #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cmwaters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request advances CIP-040, a proposal concerning the extension of the CometBFT privval interface, to the "Last Call" stage. This signifies that the proposal is nearing its finalization, and a specific deadline has been set for community feedback before its potential adoption.
Highlights
- CIP-040 Status Update: The status of CIP-040, which outlines an extension to the CometBFT privval interface, has been updated from "Review" to "Last Call".
- Last Call Deadline Added: A new field,
last-call-deadline, has been added to CIP-040, setting the deadline for the last call period to2025-09-02.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates CIP-40's status to 'Last Call' and adds a corresponding last-call-deadline. The change is straightforward and correct in its intent. However, it introduces a minor formatting issue in the markdown table by misaligning the columns. I've added a comment with a suggestion to fix the table's formatting for consistency and readability.
| | discussions-to | <https://forum.celestia.org/t/cip-40-privval-interface-extension-for-arbitrary-message-signing/2102> | | ||
| | status | Review | | ||
| | status | Last Call | | ||
| | last-call-deadline | 2025-09-02 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new line breaks the alignment of the markdown table's columns. The key last-call-deadline is longer than the keys in the surrounding rows, causing the | separator to be shifted. The repository's README.md mentions that files should conform to markdownlint, and misaligned tables can be a source of linting errors. For consistency and readability, please reformat the entire table so that all columns are properly aligned. This will likely require adjusting the padding on all rows in this table's header.
No description provided.