chore: move CIP 41 to last call #354
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cmwaters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request advances CIP-041 to the "Last Call" stage, signifying its progression towards finalization. It also clarifies a key implementation detail regarding the increase in minimum validator commission, specifying that this change will occur as part of a major upgrade migration rather than through a separate governance vote. This update ensures the proposal's status is accurately reflected and its implementation path is clearly defined.
Highlights
- CIP-041 Status Update: The status of CIP-041 has been updated from "Review" to "Last Call", indicating it is nearing finalization.
- Last Call Deadline: A deadline of September 2, 2025, has been set for the Last Call period of CIP-041.
- Minimum Commission Implementation Clarification: The method for increasing the minimum validator commission has been clarified to be a migration in the next major upgrade, rather than a governance vote.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates CIP-41 to 'Last Call' status, setting a deadline and clarifying an implementation detail. Specifically, the method for increasing the minimum validator commission is changed from a governance vote to a migration within a major upgrade. My review identified a resulting inconsistency: the 'Backwards Compatibility' section was not updated and still refers to a governance proposal for this change. I've added a comment to highlight this and recommend an update for consistency.
|
|
||
| 1. **Reduce Inflation Rate**: Decrease the current inflation rate from 5% to 2.5% in the next major upgrade (v5) | ||
| 2. **Increase Minimum Commission**: Raise the minimum validator commission from 5% to 10% via governance vote | ||
| 2. **Increase Minimum Commission**: Raise the minimum validator commission from 5% to 10% as a migration in the next major upgrade (not via governance) |
There was a problem hiding this comment.
This change clarifies that the minimum commission increase will be implemented as a migration, not via a governance vote. However, this contradicts the Backwards Compatibility section, which still states on line 101: 'This will need to be done as a governance proposal...'. Please update the Backwards Compatibility section to align with this change for consistency.
No description provided.