docs: remove feeaddress from v7#386
Conversation
Summary of ChangesHello @rootulp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for the Hibiscus (v7) network upgrade by removing a previously listed Celo Improvement Proposal (CIP). The change ensures that the official list of included CIPs in Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes CIP-43 (Fee address module) from the list of CIPs included in the Hibiscus (v7) network upgrade. The change is correct, but I've noticed an inconsistency it introduces: CIP-43 is still listed in the requires field of the document header. I've left a comment with details on how to fix this.
|
|
||
| ### Included CIPs | ||
|
|
||
| - [CIP-43](./cip-043.md): Fee address module |
|
|
||
| ### Included CIPs | ||
|
|
||
| - [CIP-43](./cip-043.md): Fee address module |
jcstein
left a comment
There was a problem hiding this comment.
PR is good. description should have a reasoning
The feeaddress implementation in celestia-app was rushed and entirely AI written. Since it isn't critical for the interop team to have it included in v7, we're reverting it.