Skip to content

Comments

docs: remove feeaddress from v7#386

Merged
rootulp merged 1 commit intocelestiaorg:mainfrom
rootulp:rp/remove-feeaddress-from-v7
Jan 30, 2026
Merged

docs: remove feeaddress from v7#386
rootulp merged 1 commit intocelestiaorg:mainfrom
rootulp:rp/remove-feeaddress-from-v7

Conversation

@rootulp
Copy link
Collaborator

@rootulp rootulp commented Jan 30, 2026

The feeaddress implementation in celestia-app was rushed and entirely AI written. Since it isn't critical for the interop team to have it included in v7, we're reverting it.

@rootulp rootulp self-assigned this Jan 30, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rootulp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for the Hibiscus (v7) network upgrade by removing a previously listed Celo Improvement Proposal (CIP). The change ensures that the official list of included CIPs in cip-047.md accurately reflects the current scope of the v7 upgrade.

Highlights

  • Documentation Update: Removed the reference to CIP-43: Fee address module from cips/cip-047.md, which lists the CIPs included in the Hibiscus (v7) network upgrade.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes CIP-43 (Fee address module) from the list of CIPs included in the Hibiscus (v7) network upgrade. The change is correct, but I've noticed an inconsistency it introduces: CIP-43 is still listed in the requires field of the document header. I've left a comment with details on how to fix this.


### Included CIPs

- [CIP-43](./cip-043.md): Fee address module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've correctly removed CIP-43 from the list of included CIPs in this section, it's still listed in the requires field in the document's header on line 10. To maintain consistency, please remove [CIP-43](./cip-043.md) from the requires field as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason?


### Included CIPs

- [CIP-43](./cip-043.md): Fee address module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason?

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good. description should have a reasoning

@rootulp rootulp merged commit 589b2cb into celestiaorg:main Jan 30, 2026
4 of 5 checks passed
@rootulp rootulp deleted the rp/remove-feeaddress-from-v7 branch February 3, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants