chore: gitignore claude settings#388
Conversation
Summary of ChangesHello @rootulp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving repository cleanliness and developer experience by ensuring that local configuration files for Claude Code are not tracked by Git. By ignoring these files, it prevents developer-specific settings from being committed, thus maintaining a cleaner repository and avoiding potential conflicts or accidental sharing of personal configurations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file to exclude local settings for 'Claude Code'. I've suggested an improvement to ignore the entire .claude directory instead of a specific file pattern. This is a more robust approach that will prevent other local-only files from the tool from being accidentally committed in the future.
| cips/wgs/**/*.html | ||
|
|
||
| # Claude Code local settings | ||
| .claude/*.local.json |
There was a problem hiding this comment.
To ensure all local settings and temporary files from 'Claude Code' are ignored, it's generally better to ignore the entire .claude directory rather than just specific files within it. This prevents other potentially local-only files created by the tool from being accidentally committed.
.claude/
There was a problem hiding this comment.
Gemini is wrong here. .claude/settings.json is actually intended to be included in version control and shared across teammates.
See https://code.claude.com/docs/en/settings#available-scopes
jcstein
left a comment
jcstein
left a comment
There was a problem hiding this comment.
OK, but recommend gemini advice being implemented
2 participants
Claude Code adds entries to a local file named
.claude/settings.local.jsonand we don't want that file included in version control