-
Notifications
You must be signed in to change notification settings - Fork 477
fix(ledger): hidapi: unknown failure
#5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Upgrading ledger-cosmos-go did not resolve. |
Downgrading ledger-go didn't resolve. |
It looks like the multiplexer and standalone binary report no build flags even though I would expect
|
Nvm. It's just another Cosmos SDK bug. Cosmos SDK claims to report build tags but it didn't work on v3.x either
|
This commit stopped plumbing the build tags to Cosmos SDK: 67241f9 |
I forked zondax/hid, created a go.mod, replaced it locally and added debug lines to print around the error. I can add a key using Ledger so at least part of the communication works. It fails when I try to submit a tx.
|
To close the loop on this, the fix was included in https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.16.0 |
hidapi: unknown failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to also backport this to v5.x
Yes definitely 👍 #5665 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks rootul on following through with this!
Closes #5453 by upgrading to https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.16.0
Testing
On a Ledger Nano S+ with Cosmos app: v2.37.6, this works:
Follow ups
Update celestiaorg/cosmos-sdk to use ledger-cosmos-go v0.16.0 so that we can remove the replace here.