fix: MsgSetRoutingIsmDomain amino signing#6543
Merged
rootulp merged 4 commits intocelestiaorg:mainfrom Feb 11, 2026
Merged
Conversation
…iaorg#6541) Add a regression test that reproduces the failure when submitting MsgSetRoutingIsmDomain from a multisig account. The malformed amino.name in the upstream hyperlane-cosmos proto definition causes SIGN_MODE_LEGACY_AMINO_JSON signing to fail with "unknown protobuf field". Includes commented-out code for the full end-to-end multisig flow to uncomment once the upstream fix lands. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
rootulp
force-pushed
the
rootulp/multisig-routing-ism-regression-test
branch
from
760e89e to
f313395
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
Blocked on bcp-innovations/hyperlane-cosmos#157 |
rootulp
requested review from
cmwaters,
mcrakhman and
ninabarbakadze
as code owners
Collaborator
Author
|
https://github.com/bcp-innovations/hyperlane-cosmos/releases/tag/v1.1.0 was released with the fix |
Collaborator
Author
|
Giving myself permission to override PRs b/c everyone is OOO or offline and this is blocking v7.0.1-arabica. |
rootulp
changed the title
MsgSetRoutingIsmDomain amino signing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6541
Summary
MsgSetRoutingIsmDomainfrom a multisig account fails due to a malformedamino.namein the upstream hyperlane-cosmos proto definition.MsgSetRoutingIsmDomainwithSIGN_MODE_LEGACY_AMINO_JSON. It asserts the expected"unknown protobuf field"error.Test plan
go test -v -run TestHyperlaneTestSuite/TestMultisigSetRoutingIsmDomain ./test/interop/passes-count=3make buildsucceedsgolangci-lintreports 0 issues🤖 Generated with Claude Code