fix: use configurable block wait timeout in TestSyncToTipMocha#7018
Draft
fix: use configurable block wait timeout in TestSyncToTipMocha#7018
Conversation
The sync-to-tip test was failing because tastora's Chain.Start() has a hardcoded 120-second timeout waiting for 2 blocks. State syncing to Mocha consumes most of that time, leaving insufficient time for block sync. Use the new WithBlockWaitTimeout to set the timeout to the test's syncToTipTimeout (10 minutes). Closes #7017 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
rach-id
approved these changes
Apr 9, 2026
Collaborator
Author
|
Draft mode until celestiaorg/tastora#189 merges and gets released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithBlockWaitTimeout(tastora#189)WithBlockWaitTimeout(syncToTipTimeout)inTestSyncToTipMochaso the 10-minute test timeout also applies to the block wait inChain.Start()Chain.Start()had a hardcoded 120s block wait which was too short for state sync nodes connecting to MochaCloses #7017
Test plan
TestSyncToTipMochapasses in nightly CI after tastora#189 is merged and a release is tagged🤖 Generated with Claude Code