feat!: check rlc when downloading fibre rows#7041
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Protobuf check fails, but it is fine, because we didn't release fibre, so I think we can change the definitions. |
|
Update: those were Claude generated review comments. I'm still manually reviewing, so far LGTM but haven't finished yet. |
rootulp
left a comment
There was a problem hiding this comment.
LGTM. I don't have any other feedback besides the Claude generated comments above
# Conflicts: # fibre/store_bench_test.go
Overview
Now if the download failed we check rlc for the downloaded rows to filter rows with incorrect encoding.
Important: check the full description (https://linear.app/celestia/issue/PROTOCO-1330/check-encoding-correctness-rlc-when-downloading-rows) of the change and why it was made here before attempting to review.