feat(fibre-txsim): async tx confirmation for pipelined uploads#7061
Merged
feat(fibre-txsim): async tx confirmation for pipelined uploads#7061
Conversation
Workers now encode + upload + broadcast the PFF transaction, then immediately start the next blob. Confirmation polling is handled by 8 background goroutines reading from a buffered channel, decoupling upload throughput from on-chain confirmation latency (~5s per tx). Upload-only mode is unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e concurrency - Each confirmRequest now carries its own txClient reference so confirmation workers always use the same client that broadcast the tx (fixes cross-client tracker issues) - Added concurrency >= 1 validation at startup Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace TxClient.ConfirmTx with a lightweight TxStatus poll via raw gRPC. ConfirmTx modifies the signer sequence on rejection/eviction without holding the client mutex, which races with concurrent BroadcastTx calls. Since fibre-txsim doesn't need sequence recovery or tx resubmission, a direct status poll is sufficient and race-free.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
go build -tags="ledger" ./tools/fibre-txsim/compiles--upload-only— behavior unchanged--upload-only— pipelined uploads with async confirmationCloses https://linear.app/celestia/issue/PROTOCO-1494/fibre-txsim-async-tx-confirmation-for-pipelined-uploads
🤖 Generated with Claude Code