feat: generate a commented out config.toml so defaults can be changed #1536

[cmwaters]

Description
Tested this using the single-node.sh script in celestia-app. Note that the moniker should stay as it's set in the init and sometimes used by the CLI

Closes: #1518

[evan-forbes]

does this break the overriding of configs from app, where now we have to modify things here?

https://github.com/celestiaorg/celestia-app/blob/be15966a34b2e29861e0a31f528438ffd6c7d1a2/app/default_overrides.go#L267-L291

[cmwaters]

does this break the overriding of configs from app, where now we have to modify things here?

https://github.com/celestiaorg/celestia-app/blob/be15966a34b2e29861e0a31f528438ffd6c7d1a2/app/default_overrides.go#L267-L291

It shouldn't. If a field is empty the default is used which I believe should be the default we override with unless we force write the new default values

[evan-forbes]

don't think we should merge this into v0.38 (originally made sense to target ofc but we've since switched)

[evan-forbes]

I think this could break some validator setup scripts, and people use sed to change configs

[cmwaters]

I think this could break some validator setup scripts, and people use sed to change configs

Yes I can imagine it will (for example setting up state sync with the trusted height and hash). If we don't want this feature, I can close the PR. It just makes it difficult to tweak defaults (which we've done a couple times in the past)

[ninabarbakadze]

do we still want this? @cmwaters

[cmwaters]

It's not relevant for now. I think we have update-config and the overrides in the short term. I think longer term requires more of a discussion