feat: re-work seed-mode, especially in PEX #2181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzdybal
force-pushed
the
tzdybal/seed_pex
branch
2 times, most recently
from
1de789e to
deb682e
Compare
Add validation to ensure that seed nodes cannot have RPC enabled, following ADR-052 guidelines. Return specific error if `rpc.laddr` is set for seed nodes.
tzdybal
force-pushed
the
tzdybal/seed_pex
branch
from
deb682e to
4044620
Compare
Member
Author
|
Replaced by #2273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the CONTRIBUTING.md file for detailed contribution guidelines.