refactor(propagation): async block decoding in handleRecoveryPart #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
we can avoid merging this one as well its probably okay since talis networks were still able to produce 128MB blocks fine even with hitting the limit |
Member
Author
|
eventually I do think we should merge something similar to avoid blocking but meh |
Member
|
100% agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converts block decoding to not block but also stops requesting parts
the latter might cause problems if we're not careful so we should add a flup to try and provide a stronger guarantee this never gets turned on or off when its not supposed to. idk what that would look like, but worth thinking about