chore: also reduce the throughput when only the legacy block prop is running #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Dec 1, 2025
| propagator = propagationReactor | ||
|
|
||
| if config.Consensus.EnableLegacyBlockProp { | ||
| types.MaxBlockSizeBytes = types.ReducedMaxBlockSizeBytes // reduce the max block size to avoid overloading the legacy block prop mechanism |
Member
There was a problem hiding this comment.
is this consensus breaking? like, do we use the var to validate blocks or only for our own usage
Member
Author
There was a problem hiding this comment.
this is used when receiving the proposal and block parts. So if we run a binary with a max block size bytes of 8mb, whenever anyone sends an >8mb block, we won't accept its proposal or block parts.
also when proposing, we will only propose blocks that are < 8mb.
So if we enable and the network is producing 128mb blocks, we won't be able to follow it.
We want this in case the propagation reactor fails, we can switch to this and make sure the network stays alive with reduced throughput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2694