don't review will be split up: feat: unified catchup and blocksync #2716
+10,815
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extended commit from the vote extensions
evan-forbes
commented
Dec 15, 2025
Member
Author
evan-forbes
left a comment
evan-forbes
left a comment
There was a problem hiding this comment.
vast majority of the new LoC are tests and documentation, so don't let the 10k scare anyone
Comment on lines
+1
to
+7
| # Implementation Plan: Unified Pending Block Manager | ||
|
|
||
| ## Overview | ||
|
|
||
| This plan describes how to implement a unified `PendingBlocksManager` that consolidates: | ||
| 1. **Catchup** (part-level recovery for current consensus height) | ||
| 2. **Blocksync** (downloading historical blocks to catch up to the network) |
Member
Author
There was a problem hiding this comment.
trying something new by including the implementation planning document I was using to prompt the llms
this is actually the best place to start for reviewers
we should delete this before merging presumably
evan-forbes
changed the title
evan-forbes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented unified catchup
closes #2711
blocked by headersync
this still needs to be more thoroughly tested on talis
its a lot of code as there is a ton of boiler plate and tests. probably 2k loc of actual logic.