feat: add the ability to halt via rpc upon configuration #2738
+424
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
mcrakhman and
ninabarbakadze
as code owners
rach-id
reviewed
Jan 2, 2026
Member
rach-id
left a comment
rach-id
left a comment
There was a problem hiding this comment.
Useful functionality, we just need to be very careful not to mess mutexes in the way or panic in edge cases when handling channels
| // Debug halt: wait for unlock signal before saving block. | ||
| // This allows forcing the node into catchup mode for debugging. | ||
| // Message processing continues while waiting because locks are released. | ||
| cs.waitForDebugUnlock() |
Member
There was a problem hiding this comment.
I would be more comfortable with this change if we check whether the unsafe flag is set before we call this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to halt via rpc
the endpoints are only added if the config is set to true
this is insanely useful if there ever is a bug in catchup and we need to replicate the issue.