fix: limit the max tx results #2751
Draft
+178
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
evan-forbes,
mcrakhman,
ninabarbakadze and
rach-id
as code owners
rach-id
approved these changes
Jan 9, 2026
| return &TxIndexConfig{ | ||
| Indexer: "kv", | ||
| Indexer: "kv", | ||
| MaxSearchResults: 10000, // Default to 10000, matching DefaultMaxSearchResults in kv package |
Member
There was a problem hiding this comment.
why not use the constant directly?
| // Use configured max search results, or default if not set (0) | ||
| maxResults := cfg.TxIndex.MaxSearchResults | ||
| if maxResults == 0 { | ||
| maxResults = 10000 // DefaultMaxSearchResults from kv package |
ninabarbakadze
approved these changes
Jan 9, 2026
Collaborator
Author
|
Converting to draft b/c QuickNode still experienced OOMs even after disabling the endpoints that allow tx searches. They stop experiencing OOMs after disabling the indexer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://celestia-team.slack.com/archives/C07TJQPUDJP/p1767923097339989